From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C03D0423A2
	for <public@inbox.dpdk.org>; Tue, 10 Jan 2023 13:01:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BF3B540A8B;
	Tue, 10 Jan 2023 13:01:04 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8EB8240687
 for <test-report@dpdk.org>; Tue, 10 Jan 2023 13:01:03 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 859E81234F4; Tue, 10 Jan 2023 13:01:03 +0100 (CET)
Subject: |WARNING| pw121784 [PATCH v1 2/3] graph: pcap capture for graph nodes
In-Reply-To: <20230110115847.1965096-2-amitprakashs@marvell.com>
References: <20230110115847.1965096-2-amitprakashs@marvell.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Amit Prakash Shukla <amitprakashs@marvell.com>
Message-Id: <20230110120103.859E81234F4@dpdk.org>
Date: Tue, 10 Jan 2023 13:01:03 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121784

_coding style issues_


ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#163: FILE: lib/graph/graph_pcap_trace.c:65:
+	}
+	else

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#188: FILE: lib/graph/graph_pcap_trace.c:90:
+	fd = open(file_name, O_CREAT | O_TRUNC | O_WRONLY, 0664);

WARNING:TYPO_SPELLING: 'WRONLY' may be misspelled - perhaps 'WRONGLY'?
#188: FILE: lib/graph/graph_pcap_trace.c:90:
+	fd = open(file_name, O_CREAT | O_TRUNC | O_WRONLY, 0664);

WARNING:RETURN_VOID: void function return statements are not generally useful
#216: FILE: lib/graph/graph_pcap_trace.c:118:
+	return;
+}

ERROR:SPACING: space required before the open parenthesis '('
#242: FILE: lib/graph/graph_pcap_trace.c:144:
+	for(i = 0; i < num_packets; i++) {

total: 2 errors, 3 warnings, 332 lines checked