From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: |WARNING| pw121843 [PATCH 01/11] pipeline: add IPsec support
Date: Wed, 11 Jan 2023 21:58:44 +0100 (CET) [thread overview]
Message-ID: <20230111205844.511C91234F4@dpdk.org> (raw)
In-Reply-To: <20230111205608.87953-2-cristian.dumitrescu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121843
_coding style issues_
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#114: FILE: lib/pipeline/rte_swx_ipsec.c:5:
+#include <stdio.h>
WARNING:TYPO_SPELLING: 'bufer' may be misspelled - perhaps 'buffer'?
#239: FILE: lib/pipeline/rte_swx_ipsec.c:130:
+ /* Crypto device bufer pool for session private data. */
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#818: FILE: lib/pipeline/rte_swx_ipsec.c:709:
+ n_groups = rte_ipsec_pkt_crypto_group((const struct rte_crypto_op **)(uintptr_t)ipsec->out.cops,
WARNING:TYPO_SPELLING: 'Peform' may be misspelled - perhaps 'Perform'?
#823: FILE: lib/pipeline/rte_swx_ipsec.c:714:
+ /* Peform post-crypto IPsec processing for each group of packets that share the same SA.
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1247: FILE: lib/pipeline/rte_swx_ipsec.c:1138:
+#define CHECK(condition, msg) \
+do { \
+ if (!(condition)) { \
+ if (errmsg) \
+ *errmsg = msg; \
+ goto error; \
+ } \
+} while (0)
WARNING:SPACING: space prohibited before semicolon
#1543: FILE: lib/pipeline/rte_swx_ipsec.c:1434:
+ iv_length = 11 ;
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1561: FILE: lib/pipeline/rte_swx_ipsec.c:1452:
+ return &xform[0];
+ } else {
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#1767: FILE: lib/pipeline/rte_swx_ipsec.c:1658:
+ sa_prm->tun.next_proto = IPPROTO_IPIP; /* Assume input IP packet type as IPv4. */
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#1772: FILE: lib/pipeline/rte_swx_ipsec.c:1663:
+ sa_prm->tun.next_proto = IPPROTO_IPIP; /* Assume input IP packet type as IPv4. */
WARNING:TYPO_SPELLING: 'Aquire' may be misspelled - perhaps 'Acquire'?
#1920: FILE: lib/pipeline/rte_swx_ipsec.c:1811:
+ /* Aquire the SA resources. */
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1998: FILE: lib/pipeline/rte_swx_ipsec.h:32:
+ * ^I- IPsec block meta-data header: @see struct rte_swx_ipsec_input_packet_metadata.$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1999: FILE: lib/pipeline/rte_swx_ipsec.h:33:
+ * ^I- IPv4 header.$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2000: FILE: lib/pipeline/rte_swx_ipsec.h:34:
+ * ^I- IPv4 payload: on the inbound path, it includes the encrypted ESP packet.$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2002: FILE: lib/pipeline/rte_swx_ipsec.h:36:
+ * ^I- IPv4 header.$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2003: FILE: lib/pipeline/rte_swx_ipsec.h:37:
+ * ^I- IPv4 payload: on the outbound path, it includes the encrypted ESP packet.$
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#2016: FILE: lib/pipeline/rte_swx_ipsec.h:50:
+#include <stdio.h>
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#2329: FILE: lib/pipeline/rte_swx_ipsec.h:363:
+ * @param[inout] is_blank_or_comment
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#2332: FILE: lib/pipeline/rte_swx_ipsec.h:366:
+ * @param[inout] errmsg
total: 0 errors, 18 warnings, 2264 lines checked
parent reply other threads:[~2023-01-11 20:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230111205608.87953-2-cristian.dumitrescu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111205844.511C91234F4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).