From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3374C423AF for ; Wed, 11 Jan 2023 21:58:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F39940FAE; Wed, 11 Jan 2023 21:58:45 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 568B540A7D for ; Wed, 11 Jan 2023 21:58:44 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 511C91234F4; Wed, 11 Jan 2023 21:58:44 +0100 (CET) Subject: |WARNING| pw121843 [PATCH 01/11] pipeline: add IPsec support In-Reply-To: <20230111205608.87953-2-cristian.dumitrescu@intel.com> References: <20230111205608.87953-2-cristian.dumitrescu@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Cristian Dumitrescu Message-Id: <20230111205844.511C91234F4@dpdk.org> Date: Wed, 11 Jan 2023 21:58:44 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/121843 _coding style issues_ WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'? #114: FILE: lib/pipeline/rte_swx_ipsec.c:5: +#include WARNING:TYPO_SPELLING: 'bufer' may be misspelled - perhaps 'buffer'? #239: FILE: lib/pipeline/rte_swx_ipsec.c:130: + /* Crypto device bufer pool for session private data. */ WARNING:LONG_LINE: line length of 104 exceeds 100 columns #818: FILE: lib/pipeline/rte_swx_ipsec.c:709: + n_groups = rte_ipsec_pkt_crypto_group((const struct rte_crypto_op **)(uintptr_t)ipsec->out.cops, WARNING:TYPO_SPELLING: 'Peform' may be misspelled - perhaps 'Perform'? #823: FILE: lib/pipeline/rte_swx_ipsec.c:714: + /* Peform post-crypto IPsec processing for each group of packets that share the same SA. WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #1247: FILE: lib/pipeline/rte_swx_ipsec.c:1138: +#define CHECK(condition, msg) \ +do { \ + if (!(condition)) { \ + if (errmsg) \ + *errmsg = msg; \ + goto error; \ + } \ +} while (0) WARNING:SPACING: space prohibited before semicolon #1543: FILE: lib/pipeline/rte_swx_ipsec.c:1434: + iv_length = 11 ; WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #1561: FILE: lib/pipeline/rte_swx_ipsec.c:1452: + return &xform[0]; + } else { WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #1767: FILE: lib/pipeline/rte_swx_ipsec.c:1658: + sa_prm->tun.next_proto = IPPROTO_IPIP; /* Assume input IP packet type as IPv4. */ WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #1772: FILE: lib/pipeline/rte_swx_ipsec.c:1663: + sa_prm->tun.next_proto = IPPROTO_IPIP; /* Assume input IP packet type as IPv4. */ WARNING:TYPO_SPELLING: 'Aquire' may be misspelled - perhaps 'Acquire'? #1920: FILE: lib/pipeline/rte_swx_ipsec.c:1811: + /* Aquire the SA resources. */ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1998: FILE: lib/pipeline/rte_swx_ipsec.h:32: + * ^I- IPsec block meta-data header: @see struct rte_swx_ipsec_input_packet_metadata.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1999: FILE: lib/pipeline/rte_swx_ipsec.h:33: + * ^I- IPv4 header.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2000: FILE: lib/pipeline/rte_swx_ipsec.h:34: + * ^I- IPv4 payload: on the inbound path, it includes the encrypted ESP packet.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2002: FILE: lib/pipeline/rte_swx_ipsec.h:36: + * ^I- IPv4 header.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2003: FILE: lib/pipeline/rte_swx_ipsec.h:37: + * ^I- IPv4 payload: on the outbound path, it includes the encrypted ESP packet.$ WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'? #2016: FILE: lib/pipeline/rte_swx_ipsec.h:50: +#include WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #2329: FILE: lib/pipeline/rte_swx_ipsec.h:363: + * @param[inout] is_blank_or_comment WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #2332: FILE: lib/pipeline/rte_swx_ipsec.h:366: + * @param[inout] errmsg total: 0 errors, 18 warnings, 2264 lines checked