From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0D6D423B9
	for <public@inbox.dpdk.org>; Thu, 12 Jan 2023 19:55:18 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C00AA42DB4;
	Thu, 12 Jan 2023 19:55:18 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 7DD7742DAA
 for <test-report@dpdk.org>; Thu, 12 Jan 2023 19:55:17 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 7979D1234F4; Thu, 12 Jan 2023 19:55:17 +0100 (CET)
Subject: |WARNING| pw121956 [PATCH V4 01/11] pipeline: add IPsec support
In-Reply-To: <20230112185335.247116-2-cristian.dumitrescu@intel.com>
References: <20230112185335.247116-2-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20230112185517.7979D1234F4@dpdk.org>
Date: Thu, 12 Jan 2023 19:55:17 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121956

_coding style issues_


WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#114: FILE: lib/pipeline/rte_swx_ipsec.c:5:
+#include <stdio.h>

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1229: FILE: lib/pipeline/rte_swx_ipsec.c:1120:
+#define CHECK(condition, msg)          \
+do {                                   \
+	if (!(condition)) {            \
+		if (errmsg)            \
+			*errmsg = msg; \
+		goto error;            \
+	}                              \
+} while (0)

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1543: FILE: lib/pipeline/rte_swx_ipsec.c:1434:
+		return &xform[0];
+	} else {

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1986: FILE: lib/pipeline/rte_swx_ipsec.h:50:
+#include <stdio.h>

total: 0 errors, 4 warnings, 2234 lines checked