* |WARNING| pw122035 [PATCH] [v4,1/1] common/cnxk: add mbox locking
@ 2023-01-13 10:18 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2023-01-13 10:18 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 14758 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/122035
_apply patch failure_
Submitter: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Date: Friday, January 13 2023 09:58:30
Applied on: CommitID:83397b9f073904438965e1fda2efe76f7850fe01
Apply patch set 122035 failed:
Checking patch drivers/common/cnxk/cnxk_telemetry_npa.c...
Checking patch drivers/common/cnxk/roc_cpt.c...
Hunk #11 succeeded at 954 (offset 3 lines).
Hunk #12 succeeded at 969 (offset 3 lines).
Checking patch drivers/common/cnxk/roc_cpt_debug.c...
Checking patch drivers/common/cnxk/roc_dev.c...
Checking patch drivers/common/cnxk/roc_idev.c...
Checking patch drivers/common/cnxk/roc_idev_priv.h...
Checking patch drivers/common/cnxk/roc_mbox.c...
Checking patch drivers/common/cnxk/roc_mbox_priv.h...
Checking patch drivers/common/cnxk/roc_nix.c...
Checking patch drivers/common/cnxk/roc_nix_bpf.c...
Checking patch drivers/common/cnxk/roc_nix_debug.c...
Hunk #6 succeeded at 739 (offset -6 lines).
Hunk #7 succeeded at 1113 (offset -6 lines).
Hunk #8 succeeded at 1126 (offset -6 lines).
Hunk #9 succeeded at 1139 (offset -6 lines).
Hunk #10 succeeded at 1152 (offset -6 lines).
Checking patch drivers/common/cnxk/roc_nix_fc.c...
Checking patch drivers/common/cnxk/roc_nix_inl.c...
Checking patch drivers/common/cnxk/roc_nix_inl_dev.c...
Checking patch drivers/common/cnxk/roc_nix_mac.c...
Checking patch drivers/common/cnxk/roc_nix_mcast.c...
Checking patch drivers/common/cnxk/roc_nix_npc.c...
Checking patch drivers/common/cnxk/roc_nix_ops.c...
Checking patch drivers/common/cnxk/roc_nix_ptp.c...
Checking patch drivers/common/cnxk/roc_nix_queue.c...
Hunk #17 succeeded at 823 (offset -2 lines).
Hunk #18 succeeded at 836 (offset -2 lines).
Hunk #19 succeeded at 889 (offset -12 lines).
Hunk #20 succeeded at 912 (offset -12 lines).
Hunk #21 succeeded at 935 (offset -12 lines).
Hunk #22 succeeded at 950 (offset -12 lines).
Hunk #23 succeeded at 1097 (offset -12 lines).
Hunk #24 succeeded at 1105 (offset -12 lines).
Hunk #25 succeeded at 1138 (offset -12 lines).
Hunk #26 succeeded at 1180 (offset -11 lines).
Hunk #27 succeeded at 1229 (offset -11 lines).
Hunk #28 succeeded at 1237 (offset -11 lines).
Hunk #29 succeeded at 1270 (offset -11 lines).
Hunk #30 succeeded at 1312 (offset -10 lines).
Hunk #31 succeeded at 1320 (offset -10 lines).
Hunk #32 succeeded at 1354 (offset -11 lines).
Hunk #33 succeeded at 1417 (offset -11 lines).
Checking patch drivers/common/cnxk/roc_nix_rss.c...
Checking patch drivers/common/cnxk/roc_nix_stats.c...
Checking patch drivers/common/cnxk/roc_nix_tm.c...
Hunk #12 succeeded at 658 (offset -130 lines).
Hunk #13 succeeded at 721 (offset -135 lines).
Hunk #14 succeeded at 821 (offset -135 lines).
Hunk #15 succeeded at 836 (offset -135 lines).
Hunk #16 succeeded at 865 (offset -135 lines).
Hunk #17 succeeded at 886 (offset -135 lines).
Hunk #18 succeeded at 929 (offset -135 lines).
Hunk #19 succeeded at 941 (offset -135 lines).
Hunk #20 succeeded at 962 (offset -135 lines).
Hunk #21 succeeded at 988 (offset -135 lines).
Hunk #22 succeeded at 1003 (offset -135 lines).
Hunk #23 succeeded at 1014 (offset -135 lines).
Hunk #24 succeeded at 1314 (offset -135 lines).
Hunk #25 succeeded at 1341 (offset -135 lines).
Checking patch drivers/common/cnxk/roc_nix_tm_mark.c...
Checking patch drivers/common/cnxk/roc_nix_tm_ops.c...
Hunk #7 succeeded at 695 (offset -16 lines).
Hunk #8 succeeded at 724 (offset -16 lines).
Hunk #9 succeeded at 821 (offset -16 lines).
Hunk #10 succeeded at 843 (offset -16 lines).
Hunk #11 succeeded at 898 (offset -16 lines).
Hunk #12 succeeded at 919 (offset -16 lines).
Hunk #13 succeeded at 931 (offset -16 lines).
Hunk #14 succeeded at 957 (offset -16 lines).
Hunk #15 succeeded at 969 (offset -16 lines).
Hunk #16 succeeded at 1031 (offset -16 lines).
Hunk #17 succeeded at 1075 (offset -16 lines).
Hunk #18 succeeded at 1101 (offset -16 lines).
Hunk #19 succeeded at 1130 (offset -16 lines).
Hunk #20 succeeded at 1139 (offset -16 lines).
Hunk #21 succeeded at 1150 (offset -16 lines).
Checking patch drivers/common/cnxk/roc_nix_tm_utils.c...
Checking patch drivers/common/cnxk/roc_nix_vlan.c...
Checking patch drivers/common/cnxk/roc_npa.c...
Checking patch drivers/common/cnxk/roc_npa.h...
Checking patch drivers/common/cnxk/roc_npa_debug.c...
Checking patch drivers/common/cnxk/roc_npc.c...
Hunk #1 succeeded at 947 (offset -66 lines).
Hunk #2 succeeded at 969 (offset -66 lines).
Hunk #3 succeeded at 1068 (offset -66 lines).
Hunk #4 succeeded at 1093 (offset -66 lines).
Hunk #5 succeeded at 1124 (offset -66 lines).
Hunk #6 succeeded at 1146 (offset -66 lines).
Hunk #7 succeeded at 1162 (offset -66 lines).
Hunk #8 succeeded at 1175 (offset -66 lines).
Hunk #9 succeeded at 1416 (offset -138 lines).
Hunk #10 succeeded at 1436 (offset -138 lines).
Checking patch drivers/common/cnxk/roc_npc_mcam.c...
error: while searching for:
struct npc_mcam_alloc_counter_rsp *rsp;
int rc = -ENOSPC;
req = mbox_alloc_msg_npc_mcam_alloc_counter(mbox);
if (req == NULL)
return rc;
req->count = 1;
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
return rc;
*ctr = rsp->cntr_list[0];
return rc;
}
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:11
error: while searching for:
struct npc_mcam_oper_counter_req *req;
int rc = -ENOSPC;
req = mbox_alloc_msg_npc_mcam_free_counter(mbox);
if (req == NULL)
return rc;
req->cntr = ctr_id;
return mbox_process(mbox);
}
int
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:28
error: while searching for:
struct npc_mcam_oper_counter_rsp *rsp;
int rc = -ENOSPC;
req = mbox_alloc_msg_npc_mcam_counter_stats(mbox);
if (req == NULL)
return rc;
req->cntr = ctr_id;
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
return rc;
*count = rsp->stat;
return rc;
}
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:42
error: while searching for:
struct npc_mcam_oper_counter_req *req;
int rc = -ENOSPC;
req = mbox_alloc_msg_npc_mcam_clear_counter(mbox);
if (req == NULL)
return rc;
req->cntr = ctr_id;
return mbox_process(mbox);
}
int
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:59
error: while searching for:
struct npc_mcam_free_entry_req *req;
int rc = -ENOSPC;
req = mbox_alloc_msg_npc_mcam_free_entry(mbox);
if (req == NULL)
return rc;
req->entry = entry;
return mbox_process(mbox);
}
int
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:72
Hunk #6 succeeded at 91 (offset -8 lines).
error: while searching for:
int rc = -ENOSPC;
int i;
req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox);
if (req == NULL)
return rc;
req->contig = is_conti;
req->count = req_count;
req->priority = prio;
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:309
error: while searching for:
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
return rc;
for (i = 0; i < rsp->count; i++)
alloc_entry[i] = rsp->entry_list[i];
*resp_count = rsp->count;
if (is_conti)
alloc_entry[0] = rsp->entry;
return 0;
}
int
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:319
Hunk #9 succeeded at 344 (offset -12 lines).
Hunk #10 succeeded at 354 (offset -12 lines).
Hunk #11 succeeded at 378 (offset -12 lines).
error: while searching for:
return rc;
}
req = mbox_alloc_msg_npc_mcam_write_entry(mbox);
if (req == NULL) {
if (mcam->use_ctr)
npc_mcam_free_counter(mbox, ctr);
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:394
Hunk #13 succeeded at 429 (offset -12 lines).
Hunk #14 succeeded at 494 (offset -12 lines).
Hunk #15 succeeded at 510 (offset -12 lines).
error: while searching for:
}
}
req = mbox_alloc_msg_npc_mcam_write_entry(mbox);
if (req == NULL)
return -ENOSPC;
req->set_cntr = flow->use_ctr;
req->cntr = flow->ctr_id;
req->entry = entry;
error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:589
Hunk #17 succeeded at 653 (offset -45 lines).
Hunk #18 succeeded at 744 (offset -46 lines).
Hunk #19 succeeded at 816 (offset -46 lines).
Checking patch drivers/common/cnxk/roc_npc_mcam_dump.c...
Checking patch drivers/common/cnxk/roc_npc_utils.c...
Checking patch drivers/common/cnxk/roc_sso.c...
Checking patch drivers/common/cnxk/roc_tim.c...
Checking patch drivers/common/cnxk/version.map...
Hunk #1 succeeded at 322 (offset -2 lines).
Applied patch drivers/common/cnxk/cnxk_telemetry_npa.c cleanly.
Applied patch drivers/common/cnxk/roc_cpt.c cleanly.
Applied patch drivers/common/cnxk/roc_cpt_debug.c cleanly.
Applied patch drivers/common/cnxk/roc_dev.c cleanly.
Applied patch drivers/common/cnxk/roc_idev.c cleanly.
Applied patch drivers/common/cnxk/roc_idev_priv.h cleanly.
Applied patch drivers/common/cnxk/roc_mbox.c cleanly.
Applied patch drivers/common/cnxk/roc_mbox_priv.h cleanly.
Applied patch drivers/common/cnxk/roc_nix.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_bpf.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_debug.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_fc.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_inl.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_inl_dev.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_mac.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_mcast.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_npc.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_ops.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_ptp.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_queue.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_rss.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_stats.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_tm.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_tm_mark.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_tm_ops.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_tm_utils.c cleanly.
Applied patch drivers/common/cnxk/roc_nix_vlan.c cleanly.
Applied patch drivers/common/cnxk/roc_npa.c cleanly.
Applied patch drivers/common/cnxk/roc_npa.h cleanly.
Applied patch drivers/common/cnxk/roc_npa_debug.c cleanly.
Applied patch drivers/common/cnxk/roc_npc.c cleanly.
Applying patch drivers/common/cnxk/roc_npc_mcam.c with 9 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Rejected hunk #5.
Hunk #6 applied cleanly.
Rejected hunk #7.
Rejected hunk #8.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
Rejected hunk #12.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Rejected hunk #16.
Hunk #17 applied cleanly.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Applied patch drivers/common/cnxk/roc_npc_mcam_dump.c cleanly.
Applied patch drivers/common/cnxk/roc_npc_utils.c cleanly.
Applied patch drivers/common/cnxk/roc_sso.c cleanly.
Applied patch drivers/common/cnxk/roc_tim.c cleanly.
Applied patch drivers/common/cnxk/version.map cleanly.
diff a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c (rejected hunks)
@@ -11,14 +11,16 @@ npc_mcam_alloc_counter(struct mbox *mbox, uint16_t *ctr)
struct npc_mcam_alloc_counter_rsp *rsp;
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_alloc_counter(mbox);
+ req = mbox_alloc_msg_npc_mcam_alloc_counter(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->count = 1;
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
- return rc;
+ goto exit;
*ctr = rsp->cntr_list[0];
+exit:
+ mbox_put(mbox);
return rc;
}
@@ -28,11 +30,14 @@ npc_mcam_free_counter(struct mbox *mbox, uint16_t ctr_id)
struct npc_mcam_oper_counter_req *req;
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_free_counter(mbox);
+ req = mbox_alloc_msg_npc_mcam_free_counter(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->cntr = ctr_id;
- return mbox_process(mbox);
+ rc = mbox_process(mbox);
+exit:
+ mbox_put(mbox);
+ return rc;
}
int
@@ -42,14 +47,16 @@ npc_mcam_read_counter(struct mbox *mbox, uint32_t ctr_id, uint64_t *count)
struct npc_mcam_oper_counter_rsp *rsp;
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_counter_stats(mbox);
+ req = mbox_alloc_msg_npc_mcam_counter_stats(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->cntr = ctr_id;
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
- return rc;
+ goto exit;
*count = rsp->stat;
+exit:
+ mbox_put(mbox);
return rc;
}
@@ -59,11 +66,14 @@ npc_mcam_clear_counter(struct mbox *mbox, uint32_t ctr_id)
struct npc_mcam_oper_counter_req *req;
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_clear_counter(mbox);
+ req = mbox_alloc_msg_npc_mcam_clear_counter(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->cntr = ctr_id;
- return mbox_process(mbox);
+ rc = mbox_process(mbox);
+exit:
+ mbox_put(mbox);
+ return rc;
}
int
@@ -72,11 +82,14 @@ npc_mcam_free_entry(struct mbox *mbox, uint32_t entry)
struct npc_mcam_free_entry_req *req;
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_free_entry(mbox);
+ req = mbox_alloc_msg_npc_mcam_free_entry(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->entry = entry;
- return mbox_process(mbox);
+ rc = mbox_process(mbox);
+exit:
+ mbox_put(mbox);
+ return rc;
}
int
@@ -309,9 +325,9 @@ npc_mcam_alloc_entries(struct mbox *mbox, int ref_mcam, int *alloc_entry, int re
int rc = -ENOSPC;
int i;
- req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox);
+ req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox_get(mbox));
if (req == NULL)
- return rc;
+ goto exit;
req->contig = is_conti;
req->count = req_count;
req->priority = prio;
@@ -319,13 +335,16 @@ npc_mcam_alloc_entries(struct mbox *mbox, int ref_mcam, int *alloc_entry, int re
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
- return rc;
+ goto exit;
for (i = 0; i < rsp->count; i++)
alloc_entry[i] = rsp->entry_list[i];
*resp_count = rsp->count;
if (is_conti)
alloc_entry[0] = rsp->entry;
- return 0;
+ rc = 0;
+exit:
+ mbox_put(mbox);
+ return rc;
}
int
@@ -394,8 +419,9 @@ npc_mcam_write_entry(struct mbox *mbox, struct roc_npc_flow *mcam)
return rc;
}
- req = mbox_alloc_msg_npc_mcam_write_entry(mbox);
+ req = mbox_alloc_msg_npc_mcam_write_entry(mbox_get(mbox));
if (req == NULL) {
+ mbox_put(mbox);
if (mcam->use_ctr)
npc_mcam_free_counter(mbox, ctr);
@@ -589,9 +618,11 @@ npc_mcam_alloc_and_write(struct npc *npc, struct roc_npc_flow *flow,
}
}
- req = mbox_alloc_msg_npc_mcam_write_entry(mbox);
- if (req == NULL)
- return -ENOSPC;
+ req = mbox_alloc_msg_npc_mcam_write_entry(mbox_get(mbox));
+ if (req == NULL) {
+ rc = -ENOSPC;
+ goto exit;
+ }
req->set_cntr = flow->use_ctr;
req->cntr = flow->ctr_id;
req->entry = entry;
https://lab.dpdk.org/results/dashboard/patchsets/24975/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw122035 [PATCH v4 1/1] common/cnxk: add mbox locking
[not found] <20230113095830.3150690-1-rkudurumalla@marvell.com>
@ 2023-01-13 9:59 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2023-01-13 9:59 UTC (permalink / raw)
To: test-report; +Cc: Rakesh Kudurumalla
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122035
_coding style issues_
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7317: FILE: drivers/common/cnxk/roc_tim.c:105:
+ req = mbox_alloc_msg_tim_enable_ring(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7340: FILE: drivers/common/cnxk/roc_tim.c:136:
+ req = mbox_alloc_msg_tim_disable_ring(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7363: FILE: drivers/common/cnxk/roc_tim.c:172:
+ req = mbox_alloc_msg_tim_config_ring(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7395: FILE: drivers/common/cnxk/roc_tim.c:210:
+ req = mbox_alloc_msg_tim_get_min_intvl(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7417: FILE: drivers/common/cnxk/roc_tim.c:243:
+ req = mbox_alloc_msg_tim_lf_alloc(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7434: FILE: drivers/common/cnxk/roc_tim.c:264:
+ free_req = mbox_alloc_msg_tim_lf_free(mbox);
WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#7458: FILE: drivers/common/cnxk/roc_tim.c:292:
+ req = mbox_alloc_msg_tim_lf_free(mbox_get(dev->mbox));
total: 0 errors, 7 warnings, 6916 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-13 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 10:18 |WARNING| pw122035 [PATCH] [v4,1/1] common/cnxk: add mbox locking dpdklab
[not found] <20230113095830.3150690-1-rkudurumalla@marvell.com>
2023-01-13 9:59 ` |WARNING| pw122035 [PATCH v4 1/1] " checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).