From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: |WARNING| pw122040 [RFC PATCH v2 3/3] telemetry: use standard logging
Date: Fri, 13 Jan 2023 17:20:46 +0100 (CET) [thread overview]
Message-ID: <20230113162046.27B61123659@dpdk.org> (raw)
In-Reply-To: <20230113162001.519534-4-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122040
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#127: FILE: lib/telemetry/telemetry.c:57:
+extern int logtype;
ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: lib/telemetry/telemetry.c:60:
+ rte_log(RTE_LOG_ ## l, logtype, "TELEMETRY: " __VA_ARGS__)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: lib/telemetry/telemetry.c:60:
+ rte_log(RTE_LOG_ ## l, logtype, "TELEMETRY: " __VA_ARGS__)$
total: 1 errors, 2 warnings, 69 lines checked
next prev parent reply other threads:[~2023-01-13 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230113162001.519534-4-bruce.richardson@intel.com>
2023-01-13 16:17 ` |SUCCESS| pw122038-122040 " qemudev
2023-01-13 16:20 ` checkpatch [this message]
2023-01-13 16:21 ` qemudev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113162046.27B61123659@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).