From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E4FC7423C5
	for <public@inbox.dpdk.org>; Fri, 13 Jan 2023 17:20:47 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E5A2642E16;
	Fri, 13 Jan 2023 17:20:47 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 6DC7A42E06
 for <test-report@dpdk.org>; Fri, 13 Jan 2023 17:20:46 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 27B61123659; Fri, 13 Jan 2023 17:20:46 +0100 (CET)
Subject: |WARNING| pw122040 [RFC PATCH v2 3/3] telemetry: use standard logging
In-Reply-To: <20230113162001.519534-4-bruce.richardson@intel.com>
References: <20230113162001.519534-4-bruce.richardson@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Message-Id: <20230113162046.27B61123659@dpdk.org>
Date: Fri, 13 Jan 2023 17:20:46 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122040

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#127: FILE: lib/telemetry/telemetry.c:57:
+extern int logtype;

ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: lib/telemetry/telemetry.c:60:
+        rte_log(RTE_LOG_ ## l, logtype, "TELEMETRY: " __VA_ARGS__)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: lib/telemetry/telemetry.c:60:
+        rte_log(RTE_LOG_ ## l, logtype, "TELEMETRY: " __VA_ARGS__)$

total: 1 errors, 2 warnings, 69 lines checked