* |WARNING| pw122061 [PATCH v6 1/1] common/idpf: add AVX512 data path for split queue model
[not found] <20230114035439.299789-2-wenjun1.wu@intel.com>
@ 2023-01-14 3:37 ` qemudev
2023-01-14 3:48 ` checkpatch
1 sibling, 0 replies; 3+ messages in thread
From: qemudev @ 2023-01-14 3:37 UTC (permalink / raw)
To: test-report; +Cc: Wenjun Wu, zhoumin
Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/122061
_apply patch failure_
Submitter: Wenjun Wu <wenjun1.wu@intel.com>
Date: Sat, 14 Jan 2023 03:54:39 +0000
DPDK git baseline: Repo:dpdk-next-net-intel
Branch: main
CommitID: 43d326b6f923f32473f550228910e1bd5de3f3fb
Apply patch set 122061 failed:
Checking patch drivers/common/idpf/idpf_common_rxtx.c...
error: drivers/common/idpf/idpf_common_rxtx.c: No such file or directory
Checking patch drivers/common/idpf/idpf_common_rxtx.h...
error: drivers/common/idpf/idpf_common_rxtx.h: No such file or directory
Checking patch drivers/common/idpf/idpf_common_rxtx_avx512.c...
error: drivers/common/idpf/idpf_common_rxtx_avx512.c: No such file or directory
Checking patch drivers/common/idpf/version.map...
error: while searching for:
idpf_singleq_xmit_pkts;
idpf_prep_pkts;
idpf_singleq_rx_vec_setup;
idpf_singleq_tx_vec_setup_avx512;
idpf_singleq_recv_pkts_avx512;
idpf_singleq_xmit_pkts_avx512;
local: *;
};
error: patch failed: drivers/common/idpf/version.map:44
error: drivers/common/idpf/version.map: patch does not apply
Checking patch drivers/net/idpf/idpf_rxtx.c...
error: while searching for:
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512)
#ifdef CC_AVX512_SUPPORT
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1)
vport->rx_use_avx512 = true;
#else
PMD_DRV_LOG(NOTICE,
error: patch failed: drivers/net/idpf/idpf_rxtx.c:758
error: drivers/net/idpf/idpf_rxtx.c: patch does not apply
Checking patch drivers/net/idpf/idpf_rxtx_vec_common.h...
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw122061 [PATCH v6 1/1] common/idpf: add AVX512 data path for split queue model
[not found] <20230114035439.299789-2-wenjun1.wu@intel.com>
2023-01-14 3:37 ` |WARNING| pw122061 [PATCH v6 1/1] common/idpf: add AVX512 data path for split queue model qemudev
@ 2023-01-14 3:48 ` checkpatch
1 sibling, 0 replies; 3+ messages in thread
From: checkpatch @ 2023-01-14 3:48 UTC (permalink / raw)
To: test-report; +Cc: Wenjun Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122061
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#231: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:567:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:567:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#304: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:640:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:640:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
total: 2 errors, 2 warnings, 0 checks, 1184 lines checked
Warning in drivers/common/idpf/idpf_common_rxtx_avx512.c:
Using rte_atomicNN_xxx
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw122061 [PATCH] [v6, 1/1] common/idpf: add AVX512 data path for split queue model
@ 2023-01-14 4:08 dpdklab
0 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2023-01-14 4:08 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 6354 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/122061
_apply patch failure_
Submitter: Wenjun Wu <wenjun1.wu@intel.com>
Date: Saturday, January 14 2023 03:54:39
Applied on: CommitID:83397b9f073904438965e1fda2efe76f7850fe01
Apply patch set 122061 failed:
Checking patch drivers/common/idpf/idpf_common_rxtx.c...
error: drivers/common/idpf/idpf_common_rxtx.c: does not exist in index
Checking patch drivers/common/idpf/idpf_common_rxtx.h...
error: drivers/common/idpf/idpf_common_rxtx.h: does not exist in index
Checking patch drivers/common/idpf/idpf_common_rxtx_avx512.c...
error: drivers/common/idpf/idpf_common_rxtx_avx512.c: does not exist in index
Checking patch drivers/common/idpf/version.map...
error: while searching for:
idpf_singleq_xmit_pkts;
idpf_prep_pkts;
idpf_singleq_rx_vec_setup;
idpf_singleq_tx_vec_setup_avx512;
idpf_singleq_recv_pkts_avx512;
idpf_singleq_xmit_pkts_avx512;
local: *;
};
error: patch failed: drivers/common/idpf/version.map:44
Checking patch drivers/net/idpf/idpf_rxtx.c...
error: while searching for:
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512)
#ifdef CC_AVX512_SUPPORT
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1)
vport->rx_use_avx512 = true;
#else
PMD_DRV_LOG(NOTICE,
error: patch failed: drivers/net/idpf/idpf_rxtx.c:758
error: while searching for:
#ifdef RTE_ARCH_X86
if (vport->rxq_model == VIRTCHNL2_QUEUE_MODEL_SPLIT) {
dev->rx_pkt_burst = idpf_splitq_recv_pkts;
} else {
if (vport->rx_vec_allowed) {
for (i = 0; i < dev->data->nb_tx_queues; i++) {
rxq = dev->data->rx_queues[i];
(void)idpf_singleq_rx_vec_setup(rxq);
}
error: patch failed: drivers/net/idpf/idpf_rxtx.c:771
error: while searching for:
int i;
#endif /* CC_AVX512_SUPPORT */
if (idpf_rx_vec_dev_check_default(dev) == IDPF_VECTOR_PATH &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
vport->tx_vec_allowed = true;
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512)
#ifdef CC_AVX512_SUPPORT
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1)
vport->tx_use_avx512 = true;
#else
PMD_DRV_LOG(NOTICE,
"AVX512 is not supported in build env");
error: patch failed: drivers/net/idpf/idpf_rxtx.c:806
Hunk #4 succeeded at 2290 (offset 1443 lines).
error: while searching for:
if (vport->tx_vec_allowed) {
#ifdef CC_AVX512_SUPPORT
if (vport->tx_use_avx512) {
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
if (txq == NULL)
continue;
idpf_singleq_tx_vec_setup_avx512(txq);
}
dev->tx_pkt_burst = idpf_singleq_xmit_pkts_avx512;
dev->tx_pkt_prepare = idpf_prep_pkts;
return;
error: patch failed: drivers/net/idpf/idpf_rxtx.c:831
Checking patch drivers/net/idpf/idpf_rxtx_vec_common.h...
Applying patch drivers/common/idpf/version.map with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/idpf/idpf_rxtx.c with 4 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Hunk #4 applied cleanly.
Rejected hunk #5.
Applied patch drivers/net/idpf/idpf_rxtx_vec_common.h cleanly.
diff a/drivers/common/idpf/version.map b/drivers/common/idpf/version.map (rejected hunks)
@@ -44,9 +44,12 @@ INTERNAL {
idpf_singleq_xmit_pkts;
idpf_prep_pkts;
idpf_singleq_rx_vec_setup;
- idpf_singleq_tx_vec_setup_avx512;
+ idpf_splitq_rx_vec_setup;
+ idpf_tx_vec_setup_avx512;
idpf_singleq_recv_pkts_avx512;
+ idpf_splitq_recv_pkts_avx512;
idpf_singleq_xmit_pkts_avx512;
+ idpf_splitq_xmit_pkts_avx512;
local: *;
};
diff a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c (rejected hunks)
@@ -758,7 +758,8 @@ idpf_set_rx_function(struct rte_eth_dev *dev)
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512)
#ifdef CC_AVX512_SUPPORT
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1)
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1 &&
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512DQ))
vport->rx_use_avx512 = true;
#else
PMD_DRV_LOG(NOTICE,
@@ -771,10 +772,24 @@ idpf_set_rx_function(struct rte_eth_dev *dev)
#ifdef RTE_ARCH_X86
if (vport->rxq_model == VIRTCHNL2_QUEUE_MODEL_SPLIT) {
+#ifdef RTE_ARCH_X86
+ if (vport->rx_vec_allowed) {
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ rxq = dev->data->rx_queues[i];
+ (void)idpf_splitq_rx_vec_setup(rxq);
+ }
+#ifdef CC_AVX512_SUPPORT
+ if (vport->rx_use_avx512) {
+ dev->rx_pkt_burst = idpf_splitq_recv_pkts_avx512;
+ return;
+ }
+#endif
+ }
+#endif
dev->rx_pkt_burst = idpf_splitq_recv_pkts;
} else {
if (vport->rx_vec_allowed) {
- for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
rxq = dev->data->rx_queues[i];
(void)idpf_singleq_rx_vec_setup(rxq);
}
@@ -806,14 +821,22 @@ idpf_set_tx_function(struct rte_eth_dev *dev)
int i;
#endif /* CC_AVX512_SUPPORT */
- if (idpf_rx_vec_dev_check_default(dev) == IDPF_VECTOR_PATH &&
+ if (idpf_tx_vec_dev_check_default(dev) == IDPF_VECTOR_PATH &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
vport->tx_vec_allowed = true;
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512)
#ifdef CC_AVX512_SUPPORT
+ {
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) == 1)
vport->tx_use_avx512 = true;
+ if (vport->tx_use_avx512) {
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ txq = dev->data->tx_queues[i];
+ idpf_tx_vec_setup_avx512(txq);
+ }
+ }
+ }
#else
PMD_DRV_LOG(NOTICE,
"AVX512 is not supported in build env");
@@ -831,12 +865,6 @@ idpf_set_tx_function(struct rte_eth_dev *dev)
if (vport->tx_vec_allowed) {
#ifdef CC_AVX512_SUPPORT
if (vport->tx_use_avx512) {
- for (i = 0; i < dev->data->nb_tx_queues; i++) {
- txq = dev->data->tx_queues[i];
- if (txq == NULL)
- continue;
- idpf_singleq_tx_vec_setup_avx512(txq);
- }
dev->tx_pkt_burst = idpf_singleq_xmit_pkts_avx512;
dev->tx_pkt_prepare = idpf_prep_pkts;
return;
https://lab.dpdk.org/results/dashboard/patchsets/24982/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-14 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230114035439.299789-2-wenjun1.wu@intel.com>
2023-01-14 3:37 ` |WARNING| pw122061 [PATCH v6 1/1] common/idpf: add AVX512 data path for split queue model qemudev
2023-01-14 3:48 ` checkpatch
2023-01-14 4:08 |WARNING| pw122061 [PATCH] [v6, " dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).