From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vipin P R <vipinp@vmware.com>
Subject: |WARNING| pw122075 [PATCH] Memory Allocation: Adding a new UT for fb_array
Date: Sun, 15 Jan 2023 21:13:33 +0100 (CET) [thread overview]
Message-ID: <20230115201333.7C91D123659@dpdk.org> (raw)
In-Reply-To: <1673615567-20873-2-git-send-email-vipinp@vmware.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122075
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: app/test/test_fbarray.c:409:
+ struct rte_fbarray test_array;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: app/test/test_fbarray.c:410:
+ int input[] = {1, 1070, 1, 2, 1, 2, 4, 12, 2, 2, 1, 2, 1};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: app/test/test_fbarray.c:411:
+ int ms_idx, prev_ms_idx, delta;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: app/test/test_fbarray.c:412:
+ int len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: app/test/test_fbarray.c:413:
+ ms_idx = prev_ms_idx = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: app/test/test_fbarray.c:415:
+ int ret = rte_fbarray_init(&test_array, "test", 32768, sizeof(struct rte_memseg));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: app/test/test_fbarray.c:416:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: app/test/test_fbarray.c:417:
+ RTE_LOG(DEBUG, EAL, "FB array init success
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: app/test/test_fbarray.c:417:
+ RTE_LOG(DEBUG, EAL, "FB array init success
");$
ERROR:CODE_INDENT: code indent should use tabs where possible
#144: FILE: app/test/test_fbarray.c:418:
+ int k = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: app/test/test_fbarray.c:418:
+ int k = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#145: FILE: app/test/test_fbarray.c:419:
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: app/test/test_fbarray.c:419:
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#145: FILE: app/test/test_fbarray.c:419:
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {
+ if (i == 0) {
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#145: FILE: app/test/test_fbarray.c:419:
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {
^
ERROR:SPACING: space required before the open parenthesis '('
#145: FILE: app/test/test_fbarray.c:419:
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#146: FILE: app/test/test_fbarray.c:420:
+ if (i == 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: app/test/test_fbarray.c:420:
+ if (i == 0) {$
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#146: FILE: app/test/test_fbarray.c:420:
+ if (i == 0) {
[...]
+ } else {
[...]
ERROR:CODE_INDENT: code indent should use tabs where possible
#147: FILE: app/test/test_fbarray.c:421:
+ len = input[i];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: app/test/test_fbarray.c:421:
+ len = input[i];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#148: FILE: app/test/test_fbarray.c:422:
+ } else {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: app/test/test_fbarray.c:422:
+ } else {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#149: FILE: app/test/test_fbarray.c:423:
+ len = input[i] + 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#149: FILE: app/test/test_fbarray.c:423:
+ len = input[i] + 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#150: FILE: app/test/test_fbarray.c:424:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: app/test/test_fbarray.c:424:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#151: FILE: app/test/test_fbarray.c:425:
+ prev_ms_idx = ms_idx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: app/test/test_fbarray.c:425:
+ prev_ms_idx = ms_idx;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: app/test/test_fbarray.c:426:
+ ms_idx = rte_fbarray_find_next_n_free(&test_array, k, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: app/test/test_fbarray.c:426:
+ ms_idx = rte_fbarray_find_next_n_free(&test_array, k, len);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#154: FILE: app/test/test_fbarray.c:428:
+ if (i != 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#154: FILE: app/test/test_fbarray.c:428:
+ if (i != 0) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#154: FILE: app/test/test_fbarray.c:428:
+ if (i != 0) {
+ ms_idx++;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: app/test/test_fbarray.c:429:
+ ms_idx++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: app/test/test_fbarray.c:429:
+ ms_idx++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: app/test/test_fbarray.c:430:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: app/test/test_fbarray.c:430:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: app/test/test_fbarray.c:432:
+ for (int j=0; j < input[i]; j++) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: app/test/test_fbarray.c:432:
+ for (int j=0; j < input[i]; j++) {$
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#158: FILE: app/test/test_fbarray.c:432:
+ for (int j=0; j < input[i]; j++) {
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: app/test/test_fbarray.c:433:
+ RTE_LOG(DEBUG, EAL, "ms_idx:%d
", ms_idx);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: app/test/test_fbarray.c:433:
+ RTE_LOG(DEBUG, EAL, "ms_idx:%d
", ms_idx);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: app/test/test_fbarray.c:434:
+ rte_fbarray_set_used(&test_array, ms_idx);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: app/test/test_fbarray.c:434:
+ rte_fbarray_set_used(&test_array, ms_idx);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: app/test/test_fbarray.c:435:
+ ms_idx++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: app/test/test_fbarray.c:435:
+ ms_idx++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: app/test/test_fbarray.c:436:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: app/test/test_fbarray.c:436:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: app/test/test_fbarray.c:438:
+ if (prev_ms_idx) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: app/test/test_fbarray.c:438:
+ if (prev_ms_idx) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#165: FILE: app/test/test_fbarray.c:439:
+ /* The value of ms_idx should be monotonically increasing$
ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: app/test/test_fbarray.c:440:
+ * given the above input sequence in test_array.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: app/test/test_fbarray.c:441:
+ * */$
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#167: FILE: app/test/test_fbarray.c:441:
+ * */
ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: app/test/test_fbarray.c:442:
+ delta = ms_idx - prev_ms_idx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: app/test/test_fbarray.c:442:
+ delta = ms_idx - prev_ms_idx;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#169: FILE: app/test/test_fbarray.c:443:
+ if (!(delta > 0)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: app/test/test_fbarray.c:443:
+ if (!(delta > 0)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#169: FILE: app/test/test_fbarray.c:443:
+ if (!(delta > 0)) {
+ RTE_LOG(ERR, EAL, "ms_idx jumping behind. ms_idx: %d prev_ms_idx: %d
", ms_idx - 1, prev_ms_idx - 1);
WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#170: FILE: app/test/test_fbarray.c:444:
+ RTE_LOG(ERR, EAL, "ms_idx jumping behind. ms_idx: %d prev_ms_idx: %d
", ms_idx - 1, prev_ms_idx - 1);
ERROR:CODE_INDENT: code indent should use tabs where possible
#170: FILE: app/test/test_fbarray.c:444:
+ RTE_LOG(ERR, EAL, "ms_idx jumping behind. ms_idx: %d prev_ms_idx: %d
", ms_idx - 1, prev_ms_idx - 1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: app/test/test_fbarray.c:444:
+ RTE_LOG(ERR, EAL, "ms_idx jumping behind. ms_idx: %d prev_ms_idx: %d
", ms_idx - 1, prev_ms_idx - 1);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#171: FILE: app/test/test_fbarray.c:445:
+ TEST_ASSERT(0, "Incorrect ms_idx jump");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: app/test/test_fbarray.c:445:
+ TEST_ASSERT(0, "Incorrect ms_idx jump");$
ERROR:CODE_INDENT: code indent should use tabs where possible
#172: FILE: app/test/test_fbarray.c:446:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: app/test/test_fbarray.c:446:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: app/test/test_fbarray.c:447:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: app/test/test_fbarray.c:447:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: app/test/test_fbarray.c:448:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: app/test/test_fbarray.c:448:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#175: FILE: app/test/test_fbarray.c:449:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#176: FILE: app/test/test_fbarray.c:450:
+ return 0;$
total: 32 errors, 41 warnings, 67 lines checked
Warning in app/test/test_fbarray.c:
Declaring a variable inside for()
Vipin P R <vipinp@vmware.com> is unknown, please fix the commit message or update .mailmap.
Kumara Parameshwaran mail differs from primary mail, please fix the commit message or update .mailmap.
next prev parent reply other threads:[~2023-01-15 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1673615567-20873-2-git-send-email-vipinp@vmware.com>
2023-01-15 20:10 ` |SUCCESS| " qemudev
2023-01-15 20:13 ` checkpatch [this message]
2023-01-15 20:14 ` |FAILURE| " qemudev
2023-01-15 23:31 |WARNING| " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230115201333.7C91D123659@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=vipinp@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).