Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/122084 _apply patch failure_ Submitter: Nithin Dabilpuram Date: Monday, January 16 2023 09:39:54 Applied on: CommitID:83397b9f073904438965e1fda2efe76f7850fe01 Apply patch set 122084-122092 failed: Checking patch drivers/common/cnxk/roc_nix_tm.c... error: while searching for: mbox = dev->mbox; /* Sync NDC-NIX-TX for LF */ ndc_req = mbox_alloc_msg_ndc_sync_op(mbox); if (ndc_req == NULL) return -EFAULT; ndc_req->nix_lf_tx_sync = 1; if (mbox_process(mbox)) rc |= NIX_ERR_NDC_SYNC; if (rc) plt_err("NDC_SYNC failed rc %d", rc); error: patch failed: drivers/common/cnxk/roc_nix_tm.c:690 error: while searching for: mbox_put(mbox); goto alloc_err; } mbox_put(mbox); nix_tm_copy_rsp_to_nix(nix, rsp); } while (pend); nix->tm_link_cfg_lvl = rsp->link_cfg_lvl; error: patch failed: drivers/common/cnxk/roc_nix_tm.c:1480 Applying patch drivers/common/cnxk/roc_nix_tm.c with 2 rejects... Rejected hunk #1. Rejected hunk #2. diff a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c (rejected hunks) @@ -690,13 +690,16 @@ roc_nix_tm_sq_free_pending_sqe(struct nix *nix, int q) mbox = dev->mbox; /* Sync NDC-NIX-TX for LF */ - ndc_req = mbox_alloc_msg_ndc_sync_op(mbox); - if (ndc_req == NULL) + ndc_req = mbox_alloc_msg_ndc_sync_op(mbox_get(mbox)); + if (ndc_req == NULL) { + mbox_put(mbox); return -EFAULT; + } ndc_req->nix_lf_tx_sync = 1; if (mbox_process(mbox)) rc |= NIX_ERR_NDC_SYNC; + mbox_put(mbox); if (rc) plt_err("NDC_SYNC failed rc %d", rc); @@ -1480,8 +1483,9 @@ nix_tm_alloc_txschq(struct nix *nix, enum roc_nix_tm_tree tree) mbox_put(mbox); goto alloc_err; } - mbox_put(mbox); + nix_tm_copy_rsp_to_nix(nix, rsp); + mbox_put(mbox); } while (pend); nix->tm_link_cfg_lvl = rsp->link_cfg_lvl; Checking patch drivers/common/cnxk/roc_nix_fc.c... Hunk #1 succeeded at 91 (offset 8 lines). Hunk #2 succeeded at 103 (offset 8 lines). Checking patch drivers/common/cnxk/roc_nix_priv.h... Hunk #1 succeeded at 202 (offset -3 lines). Checking patch drivers/common/cnxk/roc_nix_queue.c... error: while searching for: struct mbox *mbox = (&nix->dev)->mbox; volatile struct nix_cq_ctx_s *cq_ctx; uint16_t drop_thresh = NIX_CQ_THRESH_LEVEL; uint16_t cpt_lbpid = nix->bpid[0]; enum nix_q_size qsize; size_t desc_sz; int rc; error: patch failed: drivers/common/cnxk/roc_nix_queue.c:798 error: while searching for: if (roc_model_is_cn10kb() && roc_nix_inl_inb_is_enabled(roc_nix)) { cq_ctx->cq_err_int_ena |= BIT(NIX_CQERRINT_CPT_DROP); cq_ctx->cpt_drop_err_en = 1; cq_ctx->lbp_ena = 1; cq_ctx->lbpid_low = cpt_lbpid & 0x7; cq_ctx->lbpid_med = (cpt_lbpid >> 3) & 0x7; cq_ctx->lbpid_high = (cpt_lbpid >> 6) & 0x7; cq_ctx->lbp_frac = NIX_CQ_LPB_THRESH_FRAC; drop_thresh = NIX_CQ_SEC_THRESH_LEVEL; } error: patch failed: drivers/common/cnxk/roc_nix_queue.c:860 Hunk #3 succeeded at 884 (offset -78 lines). Applied patch drivers/common/cnxk/roc_nix_fc.c cleanly. Applied patch drivers/common/cnxk/roc_nix_priv.h cleanly. Applying patch drivers/common/cnxk/roc_nix_queue.c with 2 rejects... Rejected hunk #1. Rejected hunk #2. Hunk #3 applied cleanly. diff a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c (rejected hunks) @@ -798,7 +798,7 @@ roc_nix_cq_init(struct roc_nix *roc_nix, struct roc_nix_cq *cq) struct mbox *mbox = (&nix->dev)->mbox; volatile struct nix_cq_ctx_s *cq_ctx; uint16_t drop_thresh = NIX_CQ_THRESH_LEVEL; - uint16_t cpt_lbpid = nix->bpid[0]; + uint16_t cpt_lbpid = nix->cpt_lbpid; enum nix_q_size qsize; size_t desc_sz; int rc; @@ -860,11 +860,14 @@ roc_nix_cq_init(struct roc_nix *roc_nix, struct roc_nix_cq *cq) if (roc_model_is_cn10kb() && roc_nix_inl_inb_is_enabled(roc_nix)) { cq_ctx->cq_err_int_ena |= BIT(NIX_CQERRINT_CPT_DROP); cq_ctx->cpt_drop_err_en = 1; - cq_ctx->lbp_ena = 1; - cq_ctx->lbpid_low = cpt_lbpid & 0x7; - cq_ctx->lbpid_med = (cpt_lbpid >> 3) & 0x7; - cq_ctx->lbpid_high = (cpt_lbpid >> 6) & 0x7; - cq_ctx->lbp_frac = NIX_CQ_LPB_THRESH_FRAC; + /* Enable Late BP only when non zero CPT BPID */ + if (cpt_lbpid) { + cq_ctx->lbp_ena = 1; + cq_ctx->lbpid_low = cpt_lbpid & 0x7; + cq_ctx->lbpid_med = (cpt_lbpid >> 3) & 0x7; + cq_ctx->lbpid_high = (cpt_lbpid >> 6) & 0x7; + cq_ctx->lbp_frac = NIX_CQ_LPB_THRESH_FRAC; + } drop_thresh = NIX_CQ_SEC_THRESH_LEVEL; } Checking patch drivers/common/cnxk/roc_nix.h... Checking patch drivers/common/cnxk/roc_nix_queue.c... error: drivers/common/cnxk/roc_nix_queue.c: does not match index Applied patch drivers/common/cnxk/roc_nix.h cleanly. Checking patch drivers/common/cnxk/roc_cpt.c... error: while searching for: int roc_cpt_inline_ipsec_inb_cfg_read(struct roc_cpt *roc_cpt, struct nix_inline_ipsec_cfg *inb_cfg) { struct cpt *cpt = roc_cpt_to_cpt_priv(roc_cpt); struct dev *dev = &cpt->dev; struct mbox *mbox = mbox_get(dev->mbox); struct msg_req *req; error: patch failed: drivers/common/cnxk/roc_cpt.c:268 error: while searching for: } rc = mbox_process_msg(mbox, (void *)&inb_cfg); exit: mbox_put(mbox); return rc; error: patch failed: drivers/common/cnxk/roc_cpt.c:283 Checking patch drivers/common/cnxk/roc_cpt.h... Checking patch drivers/common/cnxk/roc_mbox.h... error: while searching for: msg_rsp) \ M(NIX_RX_SW_SYNC, 0x8022, nix_rx_sw_sync, msg_req, msg_rsp) \ M(NIX_READ_INLINE_IPSEC_CFG, 0x8023, nix_read_inline_ipsec_cfg, \ msg_req, nix_inline_ipsec_cfg) \ M(NIX_LF_INLINE_RQ_CFG, 0x8024, nix_lf_inline_rq_cfg, \ nix_rq_cpt_field_mask_cfg_req, msg_rsp) \ M(NIX_SPI_TO_SA_ADD, 0x8026, nix_spi_to_sa_add, nix_spi_to_sa_add_req, \ error: patch failed: drivers/common/cnxk/roc_mbox.h:266 Hunk #2 succeeded at 1194 (offset -4 lines). Hunk #3 succeeded at 1501 (offset -4 lines). Applying patch drivers/common/cnxk/roc_cpt.c with 2 rejects... Rejected hunk #1. Rejected hunk #2. Applied patch drivers/common/cnxk/roc_cpt.h cleanly. Applying patch drivers/common/cnxk/roc_mbox.h with 1 reject... Rejected hunk #1. Hunk #2 applied cleanly. Hunk #3 applied cleanly. diff a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c (rejected hunks) @@ -268,9 +268,10 @@ roc_cpt_inline_ipsec_cfg(struct dev *cpt_dev, uint8_t lf_id, int roc_cpt_inline_ipsec_inb_cfg_read(struct roc_cpt *roc_cpt, - struct nix_inline_ipsec_cfg *inb_cfg) + struct roc_cpt_inline_ipsec_inb_cfg *cfg) { struct cpt *cpt = roc_cpt_to_cpt_priv(roc_cpt); + struct nix_inline_ipsec_cfg *inb_cfg; struct dev *dev = &cpt->dev; struct mbox *mbox = mbox_get(dev->mbox); struct msg_req *req; @@ -283,6 +284,17 @@ roc_cpt_inline_ipsec_inb_cfg_read(struct roc_cpt *roc_cpt, } rc = mbox_process_msg(mbox, (void *)&inb_cfg); + if (rc) { + rc = -EIO; + goto exit; + } + cfg->cpt_credit = inb_cfg->cpt_credit; + cfg->egrp = inb_cfg->gen_cfg.egrp; + cfg->opcode = inb_cfg->gen_cfg.opcode; + cfg->param1 = inb_cfg->gen_cfg.param1; + cfg->param2 = inb_cfg->gen_cfg.param2; + cfg->bpid = inb_cfg->bpid; + cfg->credit_th = inb_cfg->credit_th; exit: mbox_put(mbox); return rc; diff a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h (rejected hunks) @@ -266,7 +266,7 @@ struct mbox_msghdr { msg_rsp) \ M(NIX_RX_SW_SYNC, 0x8022, nix_rx_sw_sync, msg_req, msg_rsp) \ M(NIX_READ_INLINE_IPSEC_CFG, 0x8023, nix_read_inline_ipsec_cfg, \ - msg_req, nix_inline_ipsec_cfg) \ + msg_req, nix_inline_ipsec_cfg) \ M(NIX_LF_INLINE_RQ_CFG, 0x8024, nix_lf_inline_rq_cfg, \ nix_rq_cpt_field_mask_cfg_req, msg_rsp) \ M(NIX_SPI_TO_SA_ADD, 0x8026, nix_spi_to_sa_add, nix_spi_to_sa_add_req, \ https://lab.dpdk.org/results/dashboard/patchsets/24991/ UNH-IOL DPDK Community Lab