From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenjun Wu <wenjun1.wu@intel.com>
Subject: |WARNING| pw122235 [PATCH v7 1/1] common/idpf: add AVX512 data path for split queue model
Date: Wed, 18 Jan 2023 04:44:24 +0100 (CET) [thread overview]
Message-ID: <20230118034424.5D7BA123659@dpdk.org> (raw)
In-Reply-To: <20230118035139.485060-2-wenjun1.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122235
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:567:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:567:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#302: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:640:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: drivers/common/idpf/idpf_common_rxtx_avx512.c:640:
+ rte_atomic64_add(&rx_bufq->rx_stats.mbuf_alloc_failed, IDPF_RXQ_REARM_THRESH);$
CHECK:BRACES: braces {} should be used on all arms of this statement
#1304: FILE: drivers/net/idpf/idpf_rxtx_vec_common.h:86:
+ if (vport->rxq_model == VIRTCHNL2_QUEUE_MODEL_SPLIT) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1307: FILE: drivers/net/idpf/idpf_rxtx_vec_common.h:89:
+ } else
total: 2 errors, 2 warnings, 2 checks, 1188 lines checked
Warning in drivers/common/idpf/idpf_common_rxtx_avx512.c:
Using rte_atomicNN_xxx
next prev parent reply other threads:[~2023-01-18 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230118035139.485060-2-wenjun1.wu@intel.com>
2023-01-18 3:40 ` qemudev
2023-01-18 3:44 ` checkpatch [this message]
2023-01-18 3:58 |WARNING| pw122235 [PATCH] [v7, " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118034424.5D7BA123659@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).