From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 414A94240D
	for <public@inbox.dpdk.org>; Wed, 18 Jan 2023 13:59:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2A519400D6;
	Wed, 18 Jan 2023 13:59:09 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 3D05A4003F
 for <test-report@dpdk.org>; Wed, 18 Jan 2023 13:59:07 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 29044123659; Wed, 18 Jan 2023 13:59:07 +0100 (CET)
Subject: |WARNING| pw122310 [PATCH 5/5] mlx5dr: Definer,
 translate RTE quota item
In-Reply-To: <20230118125556.23622-6-getelson@nvidia.com>
References: <20230118125556.23622-6-getelson@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Message-Id: <20230118125907.29044123659@dpdk.org>
Date: Wed, 18 Jan 2023 13:59:07 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122310

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'quota->state == RTE_FLOW_QUOTA_STATE_BLOCK'
#183: FILE: drivers/net/mlx5/hws/mlx5dr_definer.c:1166:
+	if (quota && (quota->state == RTE_FLOW_QUOTA_STATE_BLOCK))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#200: FILE: drivers/net/mlx5/hws/mlx5dr_definer.c:1183:
+		return EINVAL;

total: 0 errors, 1 warnings, 1 checks, 79 lines checked