automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: |WARNING| pw122368 [PATCH v4 2/9] vhost: simplify need reply handling
Date: Thu, 19 Jan 2023 19:46:57 +0100 (CET)	[thread overview]
Message-ID: <20230119184657.E887E123D76@dpdk.org> (raw)
In-Reply-To: <20230119184620.3195267-3-david.marchand@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122368

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#72: 
Dedicate send_vhost_slave_message() helper to the case when no reply is

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#75: 
Add a send_vhost_slave_message_process_reply() helper for the opposite.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#76: 
This new helper merges both send_vhost_slave_message() and the code

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#77: 
previously in process_slave_message_reply().

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#78: 
The slave_req_lock lock is then only handled in this helper which will

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#96: FILE: lib/vhost/vhost_user.c:2871:
+send_vhost_slave_message(struct virtio_net *dev, struct vhu_msg_context *ctx)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#98: FILE: lib/vhost/vhost_user.c:2873:
+	return send_vhost_message(dev, dev->slave_req_fd, ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#102: FILE: lib/vhost/vhost_user.c:2877:
+send_vhost_slave_message_process_reply(struct virtio_net *dev, struct vhu_msg_context *ctx)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#109: FILE: lib/vhost/vhost_user.c:2882:
+	rte_spinlock_lock(&dev->slave_req_lock);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#110: FILE: lib/vhost/vhost_user.c:2883:
+	ret = send_vhost_slave_message(dev, ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#119: FILE: lib/vhost/vhost_user.c:2889:
+	ret = read_vhost_message(dev, dev->slave_req_fd, &msg_reply);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#123: FILE: lib/vhost/vhost_user.c:2893:
+				"vhost read slave message reply failed
");

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#130: FILE: lib/vhost/vhost_user.c:2900:
+	if (msg_reply.msg.request.slave != ctx->msg.request.slave) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#130: FILE: lib/vhost/vhost_user.c:2900:
+	if (msg_reply.msg.request.slave != ctx->msg.request.slave) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#133: FILE: lib/vhost/vhost_user.c:2903:
+			msg_reply.msg.request.slave, ctx->msg.request.slave);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#133: FILE: lib/vhost/vhost_user.c:2903:
+			msg_reply.msg.request.slave, ctx->msg.request.slave);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#140: FILE: lib/vhost/vhost_user.c:2910:
+	rte_spinlock_unlock(&dev->slave_req_lock);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#194: FILE: lib/vhost/vhost_user.c:3263:
+rte_vhost_slave_config_change(int vid, bool need_reply)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#229: FILE: lib/vhost/vhost_user.c:3280:
+		ret = send_vhost_slave_message(dev, &ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#232: FILE: lib/vhost/vhost_user.c:3283:
+		ret = send_vhost_slave_message_process_reply(dev, &ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#247: FILE: lib/vhost/vhost_user.c:3317:
+	ret = send_vhost_slave_message_process_reply(dev, &ctx);

total: 0 errors, 21 warnings, 163 lines checked

           reply	other threads:[~2023-01-19 18:47 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230119184620.3195267-3-david.marchand@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119184657.E887E123D76@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).