From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDDD24241A for ; Thu, 19 Jan 2023 19:47:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C22942D3D; Thu, 19 Jan 2023 19:47:01 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id ECCFF42DAC for ; Thu, 19 Jan 2023 19:46:57 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id E887E123D76; Thu, 19 Jan 2023 19:46:57 +0100 (CET) Subject: |WARNING| pw122368 [PATCH v4 2/9] vhost: simplify need reply handling In-Reply-To: <20230119184620.3195267-3-david.marchand@redhat.com> References: <20230119184620.3195267-3-david.marchand@redhat.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: David Marchand Message-Id: <20230119184657.E887E123D76@dpdk.org> Date: Thu, 19 Jan 2023 19:46:57 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/122368 _coding style issues_ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #72: Dedicate send_vhost_slave_message() helper to the case when no reply is WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #75: Add a send_vhost_slave_message_process_reply() helper for the opposite. WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #76: This new helper merges both send_vhost_slave_message() and the code WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #77: previously in process_slave_message_reply(). WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #78: The slave_req_lock lock is then only handled in this helper which will WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #96: FILE: lib/vhost/vhost_user.c:2871: +send_vhost_slave_message(struct virtio_net *dev, struct vhu_msg_context *ctx) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #98: FILE: lib/vhost/vhost_user.c:2873: + return send_vhost_message(dev, dev->slave_req_fd, ctx); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #102: FILE: lib/vhost/vhost_user.c:2877: +send_vhost_slave_message_process_reply(struct virtio_net *dev, struct vhu_msg_context *ctx) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #109: FILE: lib/vhost/vhost_user.c:2882: + rte_spinlock_lock(&dev->slave_req_lock); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #110: FILE: lib/vhost/vhost_user.c:2883: + ret = send_vhost_slave_message(dev, ctx); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #119: FILE: lib/vhost/vhost_user.c:2889: + ret = read_vhost_message(dev, dev->slave_req_fd, &msg_reply); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #123: FILE: lib/vhost/vhost_user.c:2893: + "vhost read slave message reply failed "); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #130: FILE: lib/vhost/vhost_user.c:2900: + if (msg_reply.msg.request.slave != ctx->msg.request.slave) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #130: FILE: lib/vhost/vhost_user.c:2900: + if (msg_reply.msg.request.slave != ctx->msg.request.slave) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #133: FILE: lib/vhost/vhost_user.c:2903: + msg_reply.msg.request.slave, ctx->msg.request.slave); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #133: FILE: lib/vhost/vhost_user.c:2903: + msg_reply.msg.request.slave, ctx->msg.request.slave); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #140: FILE: lib/vhost/vhost_user.c:2910: + rte_spinlock_unlock(&dev->slave_req_lock); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #194: FILE: lib/vhost/vhost_user.c:3263: +rte_vhost_slave_config_change(int vid, bool need_reply) WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #229: FILE: lib/vhost/vhost_user.c:3280: + ret = send_vhost_slave_message(dev, &ctx); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #232: FILE: lib/vhost/vhost_user.c:3283: + ret = send_vhost_slave_message_process_reply(dev, &ctx); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #247: FILE: lib/vhost/vhost_user.c:3317: + ret = send_vhost_slave_message_process_reply(dev, &ctx); total: 0 errors, 21 warnings, 163 lines checked