automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw123684 [PATCH] net/virtio-user: fix number of vrings calculation
Date: Fri, 10 Feb 2023 10:28:13 -0500 (EST)	[thread overview]
Message-ID: <20230210152813.4B396B0B3@noxus.dpdklab.iol.unh.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/123684

_apply patch failure_

Submitter: Maxime Coquelin <maxime.coquelin@redhat.com>
Date: Friday, February 10 2023 15:10:44 
Applied on: CommitID:183bdfe224760b72d3cd44f5367c80b5ee073327
Apply patch set 123684 failed:

Checking patch drivers/net/virtio/virtio_user/virtio_user_dev.c...
error: while searching for:
	bool packed_ring = !!(dev->device_features & (1ull << VIRTIO_F_RING_PACKED));

	nr_vrings = dev->max_queue_pairs * 2;
	if (dev->hw_cvq)
		nr_vrings++;

	dev->callfds = rte_zmalloc("virtio_user_dev", nr_vrings * sizeof(*dev->callfds), 0);

error: patch failed: drivers/net/virtio/virtio_user/virtio_user_dev.c:575
Applying patch drivers/net/virtio/virtio_user/virtio_user_dev.c with 1 reject...
Rejected hunk #1.
diff a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c	(rejected hunks)
@@ -575,7 +575,7 @@ virtio_user_alloc_vrings(struct virtio_user_dev *dev)
 	bool packed_ring = !!(dev->device_features & (1ull << VIRTIO_F_RING_PACKED));
 
 	nr_vrings = dev->max_queue_pairs * 2;
-	if (dev->hw_cvq)
+	if (dev->device_features & (1ull << VIRTIO_NET_F_MQ))
 		nr_vrings++;
 
 	dev->callfds = rte_zmalloc("virtio_user_dev", nr_vrings * sizeof(*dev->callfds), 0);

https://lab.dpdk.org/results/dashboard/patchsets/25345/

UNH-IOL DPDK Community Lab

             reply	other threads:[~2023-02-10 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 15:28 dpdklab [this message]
     [not found] <20230210151044.229324-1-maxime.coquelin@redhat.com>
2023-02-10 14:57 ` qemudev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210152813.4B396B0B3@noxus.dpdklab.iol.unh.edu \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).