|WARNING| pw123898 [PATCH] net/sfc: enforce fate action in transfer flow rules

|WARNING| pw123898 [PATCH] net/sfc: enforce fate action in transfer flow rules

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/123898

_apply patch failure_

Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Tue, 14 Feb 2023 17:12:47 +0400
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 92bdd498d04271b1d7e8d32a8ca7ffb1bedd31f3

Apply patch set 123898 failed:

Checking patch drivers/net/sfc/sfc_mae.c...
error: while searching for:
		SFC_ASSERT(B_FALSE);
	}

	spec_mae->action_set = sfc_mae_action_set_attach(sa, &ctx);
	if (spec_mae->action_set != NULL) {
		sfc_mae_mac_addr_del(sa, ctx.src_mac);

error: patch failed: drivers/net/sfc/sfc_mae.c:3910
error: drivers/net/sfc/sfc_mae.c: patch does not apply

|WARNING| pw123898 [PATCH] net/sfc: enforce fate action in transfer flow rules

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/123898

_coding style issues_


Ivan Malov mail differs from primary mail, please fix the commit message or update .mailmap.
Viacheslav Galaktionov mail differs from primary mail, please fix the commit message or update .mailmap.

|WARNING| pw123898 [PATCH] net/sfc: enforce fate action in transfer flow rules

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/123898

_apply patch failure_

Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Tuesday, February 14 2023 13:12:47 
Applied on: CommitID:39d469a7eb4f157923be73aea0b0cc1015860ca7
Apply patch set 123898 failed:

Checking patch drivers/net/sfc/sfc_mae.c...
error: while searching for:
		SFC_ASSERT(B_FALSE);
	}

	spec_mae->action_set = sfc_mae_action_set_attach(sa, &ctx);
	if (spec_mae->action_set != NULL) {
		sfc_mae_mac_addr_del(sa, ctx.src_mac);

error: patch failed: drivers/net/sfc/sfc_mae.c:3910
Hunk #2 succeeded at 3924 (offset -17 lines).
Applying patch drivers/net/sfc/sfc_mae.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
diff a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c	(rejected hunks)
@@ -3910,6 +3910,21 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,
 		SFC_ASSERT(B_FALSE);
 	}
 
+	/*
+	 * A DPDK flow entry must specify a fate action, which the parser
+	 * converts into a DELIVER action in a libefx action set. An
+	 * attempt to replace the action in the action set should
+	 * fail. If it succeeds then report an error, as the
+	 * parsed flow entry did not contain a fate action.
+	 */
+	rc = efx_mae_action_set_populate_drop(ctx.spec);
+	if (rc == 0) {
+		rc = rte_flow_error_set(error, EINVAL,
+					RTE_FLOW_ERROR_TYPE_ACTION, NULL,
+					"no fate action found");
+		goto fail_check_fate_action;
+	}
+
 	spec_mae->action_set = sfc_mae_action_set_attach(sa, &ctx);
 	if (spec_mae->action_set != NULL) {
 		sfc_mae_mac_addr_del(sa, ctx.src_mac);

https://lab.dpdk.org/results/dashboard/patchsets/25392/

UNH-IOL DPDK Community Lab