From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: luzhipeng <luzhipeng@cestc.cn>
Subject: |WARNING| pw124809 [PATCH] log: add timestamp for log
Date: Mon, 6 Mar 2023 08:39:59 +0100 (CET) [thread overview]
Message-ID: <20230306073959.3AAF3120D91@dpdk.org> (raw)
In-Reply-To: <20230303095435.555-1-luzhipeng@cestc.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/124809
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/eal/common/eal_common_log.c:487:
+ struct tm *info;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/eal/common/eal_common_log.c:488:
+ char date[24];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/eal/common/eal_common_log.c:489:
+ struct timespec ts;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: lib/eal/common/eal_common_log.c:490:
+ long usec;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: lib/eal/common/eal_common_log.c:492:
+ clock_gettime(CLOCK_REALTIME, &ts);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/eal/common/eal_common_log.c:493:
+ info = localtime(&ts.tv_sec);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#91: FILE: lib/eal/common/eal_common_log.c:494:
+ usec = ts.tv_nsec / 1000;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/eal/common/eal_common_log.c:495:
+ if (info == NULL) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: lib/eal/common/eal_common_log.c:496:
+ snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: lib/eal/common/eal_common_log.c:496:
+ snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: lib/eal/common/eal_common_log.c:497:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/eal/common/eal_common_log.c:497:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: lib/eal/common/eal_common_log.c:498:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: lib/eal/common/eal_common_log.c:500:
+ strftime(date, sizeof(date), "%Y-%m-%d %H:%M:%S", info);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: lib/eal/common/eal_common_log.c:501:
+ snprintf(buf, buf_size, "[%s.%06ld] ", date, usec);$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#118: FILE: lib/eal/common/eal_common_log.c:524:
+ fprintf(f,"%s ",timestamp);
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#118: FILE: lib/eal/common/eal_common_log.c:524:
+ fprintf(f,"%s ",timestamp);
^
total: 4 errors, 13 warnings, 43 lines checked
zhipeng Lu <luzhipeng@cestc.cn> is unknown, please fix the commit message or update .mailmap.
zhipeng Lu <luzhipeng@cestc.cn> is unknown, please fix the commit message or update .mailmap.
next prev parent reply other threads:[~2023-03-06 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303095435.555-1-luzhipeng@cestc.cn>
2023-03-06 7:37 ` |SUCCESS| " qemudev
2023-03-06 7:39 ` checkpatch [this message]
2023-03-06 7:41 ` qemudev
2023-03-06 9:19 |WARNING| " dpdklab
2023-03-06 9:30 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306073959.3AAF3120D91@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=luzhipeng@cestc.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).