From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw124813 [PATCH] [v7] net/i40e: fix max frame size configuration
Date: Mon, 6 Mar 2023 12:54:26 +0000 (UTC) [thread overview]
Message-ID: <20230306125426.259E060095@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/124813
_apply patch failure_
Submitter: Simei Su <simei.su@intel.com>
Date: Monday, March 06 2023 12:18:53
Applied on: CommitID:4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b
Apply patch set 124813 failed:
Checking patch drivers/net/i40e/i40e_ethdev.c...
error: while searching for:
*/
i40e_add_tx_flow_control_drop_filter(pf);
/* Set the max frame size to 0x2600 by default,
* in case other drivers changed the default value.
*/
i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, false, 0, NULL);
/* initialize RSS rule list */
TAILQ_INIT(&pf->rss_config_list);
error: patch failed: drivers/net/i40e/i40e_ethdev.c:1710
error: while searching for:
uint32_t intr_vector = 0;
struct i40e_vsi *vsi;
uint16_t nb_rxq, nb_txq;
hw->adapter_stopped = 0;
error: patch failed: drivers/net/i40e/i40e_ethdev.c:2332
Hunk #3 succeeded at 2449 (offset 1 line).
error: while searching for:
"please call hierarchy_commit() "
"before starting the port");
return I40E_SUCCESS;
tx_err:
error: patch failed: drivers/net/i40e/i40e_ethdev.c:2470
Applying patch drivers/net/i40e/i40e_ethdev.c with 3 rejects...
Rejected hunk #1.
Rejected hunk #2.
Hunk #3 applied cleanly.
Rejected hunk #4.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c (rejected hunks)
@@ -1710,11 +1710,6 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)
*/
i40e_add_tx_flow_control_drop_filter(pf);
- /* Set the max frame size to 0x2600 by default,
- * in case other drivers changed the default value.
- */
- i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, false, 0, NULL);
-
/* initialize RSS rule list */
TAILQ_INIT(&pf->rss_config_list);
@@ -2332,6 +2327,7 @@ i40e_dev_start(struct rte_eth_dev *dev)
uint32_t intr_vector = 0;
struct i40e_vsi *vsi;
uint16_t nb_rxq, nb_txq;
+ uint16_t max_frame_size;
hw->adapter_stopped = 0;
@@ -2470,6 +2466,13 @@ i40e_dev_start(struct rte_eth_dev *dev)
"please call hierarchy_commit() "
"before starting the port");
+ max_frame_size = dev->data->mtu ?
+ dev->data->mtu + I40E_ETH_OVERHEAD :
+ I40E_FRAME_SIZE_MAX;
+
+ /* Set the max frame size to HW*/
+ i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL);
+
return I40E_SUCCESS;
tx_err:
https://lab.dpdk.org/results/dashboard/patchsets/25623/
UNH-IOL DPDK Community Lab
reply other threads:[~2023-03-06 12:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306125426.259E060095@dpdk-ubuntu.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).