From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dongdong Liu <liudongdong3@huawei.com>
Subject: |WARNING| pw125005 [PATCH 15/16] net/hns3: reimplement hash flow function
Date: Fri, 10 Mar 2023 10:38:44 +0100 (CET) [thread overview]
Message-ID: <20230310093844.B6B3B1209BE@dpdk.org> (raw)
In-Reply-To: <20230310093518.5198-16-liudongdong3@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/125005
_coding style issues_
WARNING:TYPO_SPELLING: 'mulitiple' may be misspelled - perhaps 'multiple'?
#58:
Currently, hns3 driver supports setting mulitiple rte flow RSS rule,
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76:
[1] https://lore.kernel.org/all/DM5PR12MB46648085D7CABF1AFF2D75CDD60A9@DM5PR12MB4664.namprd12.prod.outlook.com/
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ (act) = (actions) + (index); \
+ while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ (index)++; \
+ (act) = (actions) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ (act) = (actions) + (index); \
+ while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ (index)++; \
+ (act) = (actions) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ (act) = (actions) + (index); \
+ while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ (index)++; \
+ (act) = (actions) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ (item) = (pattern) + (index); \
+ while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ (item) = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ (item) = (pattern) + (index); \
+ while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ (item) = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ (item) = (pattern) + (index); \
+ while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ (item) = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#619: FILE: drivers/net/hns3/hns3_flow.c:1656:
+ hns3_warn(hw, "some types in the requested RSS types (0x%" PRIx64 ") aren't supported, they are ignored.",
total: 0 errors, 2 warnings, 7 checks, 1603 lines checked
parent reply other threads:[~2023-03-10 9:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230310093518.5198-16-liudongdong3@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310093844.B6B3B1209BE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liudongdong3@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).