From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A9D8041E3A
	for <public@inbox.dpdk.org>; Fri, 10 Mar 2023 10:38:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A0E7540685;
	Fri, 10 Mar 2023 10:38:46 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id BC89140685
 for <test-report@dpdk.org>; Fri, 10 Mar 2023 10:38:44 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id B6B3B1209BE; Fri, 10 Mar 2023 10:38:44 +0100 (CET)
Subject: |WARNING| pw125005 [PATCH 15/16] net/hns3: reimplement hash flow
 function
In-Reply-To: <20230310093518.5198-16-liudongdong3@huawei.com>
References: <20230310093518.5198-16-liudongdong3@huawei.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Dongdong Liu <liudongdong3@huawei.com>
Message-Id: <20230310093844.B6B3B1209BE@dpdk.org>
Date: Fri, 10 Mar 2023 10:38:44 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/125005

_coding style issues_


WARNING:TYPO_SPELLING: 'mulitiple' may be misspelled - perhaps 'multiple'?
#58: 
Currently, hns3 driver supports setting mulitiple rte flow RSS rule,

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76: 
[1] https://lore.kernel.org/all/DM5PR12MB46648085D7CABF1AFF2D75CDD60A9@DM5PR12MB4664.namprd12.prod.outlook.com/

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#619: FILE: drivers/net/hns3/hns3_flow.c:1656:
+			hns3_warn(hw, "some types in the requested RSS types (0x%" PRIx64 ") aren't supported, they are ignored.",

total: 0 errors, 2 warnings, 7 checks, 1603 lines checked