From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw125052 [PATCH] [v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
Date: Sun, 12 Mar 2023 12:39:56 +0000 (UTC) [thread overview]
Message-ID: <20230312123956.B4A986011D@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125052
_apply patch failure_
Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Sunday, March 12 2023 10:54:26
Applied on: CommitID:0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff
Apply patch set 125052 failed:
Checking patch drivers/net/sfc/sfc_dp_rx.h...
Checking patch drivers/net/sfc/sfc_ef100_rx.c...
Hunk #1 succeeded at 810 (offset -13 lines).
error: while searching for:
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
else
rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
error: patch failed: drivers/net/sfc/sfc_ef100_rx.c:889
Checking patch drivers/net/sfc/sfc_rx.c...
Hunk #1 succeeded at 1225 (offset -17 lines).
Applied patch drivers/net/sfc/sfc_dp_rx.h cleanly.
Applying patch drivers/net/sfc/sfc_ef100_rx.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Applied patch drivers/net/sfc/sfc_rx.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c (rejected hunks)
@@ -889,11 +892,18 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr,
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
+
+ /*
+ * At the moment, this feature is used only
+ * by the representor proxy Rx queue and is
+ * essential for representor support, so if
+ * it has been requested but is unsupported,
+ * point this inconsistency out to the user.
+ */
if ((unsup_rx_prefix_fields &
- (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
- rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
- else
- rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
+ (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) &&
+ (rxq->flags & SFC_EF100_RXQ_INGRESS_MPORT))
+ return ENOTSUP;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
https://lab.dpdk.org/results/dashboard/patchsets/25698/
UNH-IOL DPDK Community Lab
next reply other threads:[~2023-03-12 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 12:39 dpdklab [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-12 11:44 dpdklab
[not found] <20230312105426.6732-1-ivan.malov@arknetworks.am>
2023-03-12 10:41 ` |WARNING| pw125052 [PATCH v3] " qemudev
2023-03-12 10:54 ` checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312123956.B4A986011D@dpdk-ubuntu.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).