From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw125356 [PATCH] net/idpf: add VF support
Date: Tue, 21 Mar 2023 14:09:54 +0000 (UTC) [thread overview]
Message-ID: <20230321140954.986D860214@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125356
_apply patch failure_
Submitter: Xing, Beilei <beilei.xing@intel.com>
Date: Tuesday, March 21 2023 06:56:01
Applied on: CommitID:33949800f1afcb7527b6e36c60c1548687ccb673
Apply patch set 125356 failed:
Checking patch drivers/net/idpf/idpf_ethdev.c...
error: while searching for:
rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter);
}
struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = {
{
.type = IDPF_CTLQ_TYPE_MAILBOX_TX,
error: patch failed: drivers/net/idpf/idpf_ethdev.c:1128
error: while searching for:
}
};
static int
idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter)
{
error: patch failed: drivers/net/idpf/idpf_ethdev.c:1163
error: while searching for:
strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
idpf_hw_pf_reset(hw);
ret = idpf_hw_pf_reset_check(hw);
if (ret != 0) {
PMD_INIT_LOG(ERR, "PF is still resetting");
goto err_reset_check;
}
ret = idpf_hw_mbx_init(hw, ctlq_info);
if (ret != 0) {
PMD_INIT_LOG(ERR, "Failed to init mailbox");
goto err_reset_check;
}
ret = idpf_adapter_init(base);
error: patch failed: drivers/net/idpf/idpf_ethdev.c:1179
Hunk #5 succeeded at 1279 (offset -117 lines).
Checking patch drivers/net/idpf/idpf_ethdev.h...
Applying patch drivers/net/idpf/idpf_ethdev.c with 3 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Hunk #5 applied cleanly.
Applied patch drivers/net/idpf/idpf_ethdev.h cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c (rejected hunks)
@@ -1128,6 +1129,23 @@ idpf_dev_alarm_handler(void *param)
rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter);
}
+static int
+idpf_hw_vf_reset_check(struct idpf_hw *hw)
+{
+ uint32_t reg;
+ int i;
+
+ for (i = 0; i < IDPF_RESET_WAIT_CNT; i++) {
+ reg = IDPF_READ_REG(hw, VFGEN_RSTAT);
+ if (reg != 0xFFFFFFFF && (reg & VFGEN_RSTAT_VFR_STATE_M))
+ return 0;
+ rte_delay_ms(1000);
+ }
+
+ PMD_INIT_LOG(ERR, "VF reset timeout");
+ return -EBUSY;
+}
+
struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = {
{
.type = IDPF_CTLQ_TYPE_MAILBOX_TX,
@@ -1163,6 +1181,41 @@ struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = {
}
};
+struct idpf_ctlq_create_info vf_ctlq_info[IDPF_CTLQ_NUM] = {
+ {
+ .type = IDPF_CTLQ_TYPE_MAILBOX_TX,
+ .id = IDPF_CTLQ_ID,
+ .len = IDPF_CTLQ_LEN,
+ .buf_size = IDPF_DFLT_MBX_BUF_SIZE,
+ .reg = {
+ .head = VF_ATQH,
+ .tail = VF_ATQT,
+ .len = VF_ATQLEN,
+ .bah = VF_ATQBAH,
+ .bal = VF_ATQBAL,
+ .len_mask = VF_ATQLEN_ATQLEN_M,
+ .len_ena_mask = VF_ATQLEN_ATQENABLE_M,
+ .head_mask = VF_ATQH_ATQH_M,
+ }
+ },
+ {
+ .type = IDPF_CTLQ_TYPE_MAILBOX_RX,
+ .id = IDPF_CTLQ_ID,
+ .len = IDPF_CTLQ_LEN,
+ .buf_size = IDPF_DFLT_MBX_BUF_SIZE,
+ .reg = {
+ .head = VF_ARQH,
+ .tail = VF_ARQT,
+ .len = VF_ARQLEN,
+ .bah = VF_ARQBAH,
+ .bal = VF_ARQBAL,
+ .len_mask = VF_ARQLEN_ARQLEN_M,
+ .len_ena_mask = VF_ARQLEN_ARQENABLE_M,
+ .head_mask = VF_ARQH_ARQH_M,
+ }
+ }
+};
+
static int
idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter)
{
@@ -1179,17 +1232,31 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a
strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
- idpf_hw_pf_reset(hw);
- ret = idpf_hw_pf_reset_check(hw);
- if (ret != 0) {
- PMD_INIT_LOG(ERR, "PF is still resetting");
- goto err_reset_check;
- }
+ if (hw->device_id == IDPF_DEV_ID_PF) {
+ idpf_hw_pf_reset(hw);
+ ret = idpf_hw_pf_reset_check(hw);
+ if (ret != 0) {
+ PMD_INIT_LOG(ERR, "PF is still resetting");
+ goto err_reset_check;
+ }
- ret = idpf_hw_mbx_init(hw, ctlq_info);
- if (ret != 0) {
- PMD_INIT_LOG(ERR, "Failed to init mailbox");
- goto err_reset_check;
+ ret = idpf_hw_mbx_init(hw, ctlq_info);
+ if (ret != 0) {
+ PMD_INIT_LOG(ERR, "Failed to init mailbox");
+ goto err_reset_check;
+ }
+ } else if (hw->device_id == IDPF_DEV_ID_VF) {
+ ret = idpf_hw_vf_reset_check(hw);
+ if (ret != 0) {
+ PMD_INIT_LOG(ERR, "VF is still resetting");
+ goto err_reset_check;
+ }
+
+ ret = idpf_hw_mbx_init(hw, vf_ctlq_info);
+ if (ret != 0) {
+ PMD_INIT_LOG(ERR, "Failed to init mailbox");
+ goto err_reset_check;
+ }
}
ret = idpf_adapter_init(base);
https://lab.dpdk.org/results/dashboard/patchsets/25814/
UNH-IOL DPDK Community Lab
next reply other threads:[~2023-03-21 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 14:09 dpdklab [this message]
[not found] <20230321065601.80171-1-beilei.xing@intel.com>
2023-03-21 7:16 ` qemudev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321140954.986D860214@dpdk-ubuntu.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).