From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C15427F7 for ; Tue, 21 Mar 2023 15:09:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CDA140A7F; Tue, 21 Mar 2023 15:09:57 +0100 (CET) Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) by mails.dpdk.org (Postfix) with ESMTP id 0228C40A7F for ; Tue, 21 Mar 2023 15:09:55 +0100 (CET) Received: by mail-pl1-f226.google.com with SMTP id bc12so15522166plb.0 for ; Tue, 21 Mar 2023 07:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1679407795; h=date:message-id:cc:to:from:subject:from:to:cc:subject:date :message-id:reply-to; bh=mRIM6fnsTeoKc6hNKHCJLUCZ9wFa/VSCoSZW+XPCB6Q=; b=D77HflQJiQ4+dhLvubd/ui2fAXwD981+XUeJrvug0bD8gcZ37aw2OacJiv1M1g0wq6 tAP1+hjkxvybUpa5IIZZHWvpaHPFR/Z+RYIiP57XT1leuS8Hg0SZUbq/+0wbCRvaaW+F +o+p3SOFhD596aBQ38nlqZN0x4LTIYKRoc6lo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407795; h=date:message-id:cc:to:from:subject:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mRIM6fnsTeoKc6hNKHCJLUCZ9wFa/VSCoSZW+XPCB6Q=; b=00izw2jenf+3sG23pKPdLjTog0cKJxHFqbnOQiqidwLFW2rrUZFGq1fzgUwn4XD0c0 mngn9qvhQu/MYM5RVTT4toHkwwbcnA8uMQ8wG87DT3UPl0i9jDddQJ38hhHQq3TIbBhJ hEjNRlr5gHN4tqpov3OFeN3+gCl4Uy1Z2/AidtQEfLFBjujxs5K/rcpb5ALJ6GJtVXii uKFDu1wD6WV3CZuq9mnRBr8fcKkuj8bRs52TlXBPyx1HIOwmlsbOM67RaTjQeCS6RJ5t SeBAMpEkHAjcHklk5PccLxwagLafRJxi1HkXhHsQu973bczupBZ1eQH1fKLgS+EztYzl VR6A== X-Gm-Message-State: AO0yUKVT0WJGIhvBTmGlOAbrSSvnVlOajPm4Jaz6nWznemfRSMmc6I/T iIeoI5Bo2rHk+Sl3nGp/2FH+4u2bFmJ1RBI9qM5SCfHb2PuLk4cNrp8KuA== X-Google-Smtp-Source: AK7set9/JAebULIcmVpvSVefJ6JyuYnhgAFuIw5aXZuHHviHEuVdNFeGQ2B0LOMdHqCeKyh+UA0I8VQF/q8U X-Received: by 2002:a17:903:230f:b0:1a0:7508:daf2 with SMTP id d15-20020a170903230f00b001a07508daf2mr2935278plh.2.1679407795192; Tue, 21 Mar 2023 07:09:55 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id e3-20020a170902784300b0019a7305762bsm1841274pln.27.2023.03.21.07.09.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Mar 2023 07:09:55 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from dpdk-ubuntu.dpdklab.iol.unh.edu (unknown [172.18.0.210]) by postal.iol.unh.edu (Postfix) with ESMTP id 9F891605246B; Tue, 21 Mar 2023 10:09:54 -0400 (EDT) Received: from dpdk-ubuntu-2.dpdklab.iol.unh.edu (localhost [IPv6:::1]) by dpdk-ubuntu.dpdklab.iol.unh.edu (Postfix) with ESMTP id 986D860214; Tue, 21 Mar 2023 14:09:54 +0000 (UTC) Subject: |WARNING| pw125356 [PATCH] net/idpf: add VF support From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain Message-Id: <20230321140954.986D860214@dpdk-ubuntu.dpdklab.iol.unh.edu> Date: Tue, 21 Mar 2023 14:09:54 +0000 (UTC) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/125356 _apply patch failure_ Submitter: Xing, Beilei Date: Tuesday, March 21 2023 06:56:01 Applied on: CommitID:33949800f1afcb7527b6e36c60c1548687ccb673 Apply patch set 125356 failed: Checking patch drivers/net/idpf/idpf_ethdev.c... error: while searching for: rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter); } struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = { { .type = IDPF_CTLQ_TYPE_MAILBOX_TX, error: patch failed: drivers/net/idpf/idpf_ethdev.c:1128 error: while searching for: } }; static int idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter) { error: patch failed: drivers/net/idpf/idpf_ethdev.c:1163 error: while searching for: strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); idpf_hw_pf_reset(hw); ret = idpf_hw_pf_reset_check(hw); if (ret != 0) { PMD_INIT_LOG(ERR, "PF is still resetting"); goto err_reset_check; } ret = idpf_hw_mbx_init(hw, ctlq_info); if (ret != 0) { PMD_INIT_LOG(ERR, "Failed to init mailbox"); goto err_reset_check; } ret = idpf_adapter_init(base); error: patch failed: drivers/net/idpf/idpf_ethdev.c:1179 Hunk #5 succeeded at 1279 (offset -117 lines). Checking patch drivers/net/idpf/idpf_ethdev.h... Applying patch drivers/net/idpf/idpf_ethdev.c with 3 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3. Rejected hunk #4. Hunk #5 applied cleanly. Applied patch drivers/net/idpf/idpf_ethdev.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c (rejected hunks) @@ -1128,6 +1129,23 @@ idpf_dev_alarm_handler(void *param) rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter); } +static int +idpf_hw_vf_reset_check(struct idpf_hw *hw) +{ + uint32_t reg; + int i; + + for (i = 0; i < IDPF_RESET_WAIT_CNT; i++) { + reg = IDPF_READ_REG(hw, VFGEN_RSTAT); + if (reg != 0xFFFFFFFF && (reg & VFGEN_RSTAT_VFR_STATE_M)) + return 0; + rte_delay_ms(1000); + } + + PMD_INIT_LOG(ERR, "VF reset timeout"); + return -EBUSY; +} + struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = { { .type = IDPF_CTLQ_TYPE_MAILBOX_TX, @@ -1163,6 +1181,41 @@ struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = { } }; +struct idpf_ctlq_create_info vf_ctlq_info[IDPF_CTLQ_NUM] = { + { + .type = IDPF_CTLQ_TYPE_MAILBOX_TX, + .id = IDPF_CTLQ_ID, + .len = IDPF_CTLQ_LEN, + .buf_size = IDPF_DFLT_MBX_BUF_SIZE, + .reg = { + .head = VF_ATQH, + .tail = VF_ATQT, + .len = VF_ATQLEN, + .bah = VF_ATQBAH, + .bal = VF_ATQBAL, + .len_mask = VF_ATQLEN_ATQLEN_M, + .len_ena_mask = VF_ATQLEN_ATQENABLE_M, + .head_mask = VF_ATQH_ATQH_M, + } + }, + { + .type = IDPF_CTLQ_TYPE_MAILBOX_RX, + .id = IDPF_CTLQ_ID, + .len = IDPF_CTLQ_LEN, + .buf_size = IDPF_DFLT_MBX_BUF_SIZE, + .reg = { + .head = VF_ARQH, + .tail = VF_ARQT, + .len = VF_ARQLEN, + .bah = VF_ARQBAH, + .bal = VF_ARQBAL, + .len_mask = VF_ARQLEN_ARQLEN_M, + .len_ena_mask = VF_ARQLEN_ARQENABLE_M, + .head_mask = VF_ARQH_ARQH_M, + } + } +}; + static int idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter) { @@ -1179,17 +1232,31 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); - idpf_hw_pf_reset(hw); - ret = idpf_hw_pf_reset_check(hw); - if (ret != 0) { - PMD_INIT_LOG(ERR, "PF is still resetting"); - goto err_reset_check; - } + if (hw->device_id == IDPF_DEV_ID_PF) { + idpf_hw_pf_reset(hw); + ret = idpf_hw_pf_reset_check(hw); + if (ret != 0) { + PMD_INIT_LOG(ERR, "PF is still resetting"); + goto err_reset_check; + } - ret = idpf_hw_mbx_init(hw, ctlq_info); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Failed to init mailbox"); - goto err_reset_check; + ret = idpf_hw_mbx_init(hw, ctlq_info); + if (ret != 0) { + PMD_INIT_LOG(ERR, "Failed to init mailbox"); + goto err_reset_check; + } + } else if (hw->device_id == IDPF_DEV_ID_VF) { + ret = idpf_hw_vf_reset_check(hw); + if (ret != 0) { + PMD_INIT_LOG(ERR, "VF is still resetting"); + goto err_reset_check; + } + + ret = idpf_hw_mbx_init(hw, vf_ctlq_info); + if (ret != 0) { + PMD_INIT_LOG(ERR, "Failed to init mailbox"); + goto err_reset_check; + } } ret = idpf_adapter_init(base); https://lab.dpdk.org/results/dashboard/patchsets/25814/ UNH-IOL DPDK Community Lab