From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BC739428CD
	for <public@inbox.dpdk.org>; Tue,  4 Apr 2023 15:33:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD79540A7E;
	Tue,  4 Apr 2023 15:33:42 +0200 (CEST)
Received: from mail-oa1-f97.google.com (mail-oa1-f97.google.com
 [209.85.160.97]) by mails.dpdk.org (Postfix) with ESMTP id 42F5B40A7E
 for <test-report@dpdk.org>; Tue,  4 Apr 2023 15:33:41 +0200 (CEST)
Received: by mail-oa1-f97.google.com with SMTP id
 586e51a60fabf-177b78067ffso34538193fac.7
 for <test-report@dpdk.org>; Tue, 04 Apr 2023 06:33:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1680615220;
 h=date:message-id:cc:to:from:subject:from:to:cc:subject:date
 :message-id:reply-to;
 bh=H4Clulx0u1J0k5zA/FXWI/o3cqcdxZruylEoGXLkZ48=;
 b=D2reu+0Jy4IpVRjk08irvuZvYTyNToH2h0EQLzpdn+i8+SuzOu9Cv7P6LoB5oKH7w0
 eP4VpstMl4l4E3ixriywYEt/56ZLF4AAX8Ccn0HxQ9COqZHQnyt5YBN6Gwh7EYYI2XA4
 7C7L8m140jCXqIuSwUyhPauGrsLTfCNTsvjSw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1680615220;
 h=date:message-id:cc:to:from:subject:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=H4Clulx0u1J0k5zA/FXWI/o3cqcdxZruylEoGXLkZ48=;
 b=B5pMYSbC5kxpjIse89TlDPrg796fZwnJSGcG1D7V4uApo+1vMpx5J6b4UOXoLjzg8l
 3Ok7y0r29ZAC/bJKDPeRqUmTLh2nJjyM1IocSL9WY4NTdlllYhhh3JrELStEM558MXuX
 nWdVy/iGkx0VgkDhiQfpWhVSvmzCmufl5LWzMda23puasPtt2P4TeEBVhS80m4QYWahS
 /W25JybOsUJ/LjrJWQokPX79ZD7eXTnrq/hweG/0EvBk1BESOXxXrYNoFHI+OJZG2dQB
 rlrLsDOH4SBov4WsGN+LM+2R7soTKzXhKYbYeZIB8Y6jKeM3JLQYxc3gwHdG6uC8w3jn
 99Rw==
X-Gm-Message-State: AAQBX9df1tq6QIVvKfysbwEqvc5SvI+XEqmy4Avu0xSIN44GVXnTcauB
 5IOoc9FmqiAikX3RKFVOyE0/GKk9Gk8ZiDeltTDMsWkKjMO4MEsB4xGNXqB86ejYS2eaXMBDxA=
 =
X-Google-Smtp-Source: AKy350YK4W3p6h9zzC67IjmBBL+AbiWi/YJaezZR2Iy40yfl6p0xyNRrd91iUrFLNSr7dZM+IM52u02bKjwU
X-Received: by 2002:a05:6870:4728:b0:17e:cb7:299b with SMTP id
 b40-20020a056870472800b0017e0cb7299bmr1567039oaq.47.1680615220519; 
 Tue, 04 Apr 2023 06:33:40 -0700 (PDT)
Received: from postal.iol.unh.edu (postal.iol.unh.edu.
 [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id
 l32-20020a0568302b2000b006a11accf05asm2636059otv.13.2023.04.04.06.33.40
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Apr 2023 06:33:40 -0700 (PDT)
X-Relaying-Domain: iol.unh.edu
Received: from dpdk-ubuntu.dpdklab.iol.unh.edu (unknown [172.18.0.210])
 by postal.iol.unh.edu (Postfix) with ESMTP id 077A1605246B;
 Tue,  4 Apr 2023 09:33:40 -0400 (EDT)
Received: from dpdk-ubuntu-2.dpdklab.iol.unh.edu (localhost [IPv6:::1])
 by dpdk-ubuntu.dpdklab.iol.unh.edu (Postfix) with ESMTP id 05C756012C;
 Tue,  4 Apr 2023 13:33:40 +0000 (UTC)
Subject: |WARNING| pw125772 [PATCH] [v2] net/idpf: add VF support
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Content-Type: text/plain
Message-Id: <20230404133340.05C756012C@dpdk-ubuntu.dpdklab.iol.unh.edu>
Date: Tue,  4 Apr 2023 13:33:40 +0000 (UTC)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125772

_apply patch failure_

Submitter: Xing, Beilei <beilei.xing@intel.com>
Date: Tuesday, April 04 2023 12:49:37 
Applied on: CommitID:c682c8991963be243dcc3b7cdc9d6984a1961f4e
Apply patch set 125772 failed:

Checking patch drivers/net/idpf/idpf_ethdev.c...
error: while searching for:
	rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter);
}

static struct idpf_ctlq_create_info idpf_ctlq_info[IDPF_CTLQ_NUM] = {
	{
		.type = IDPF_CTLQ_TYPE_MAILBOX_TX,

error: patch failed: drivers/net/idpf/idpf_ethdev.c:1128
error: while searching for:
	.other_caps = VIRTCHNL2_CAP_WB_ON_ITR
};

static int
idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter)
{

error: patch failed: drivers/net/idpf/idpf_ethdev.c:1201
error: while searching for:

	strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);

	idpf_hw_pf_reset(hw);
	ret = idpf_hw_pf_reset_check(hw);
	if (ret != 0) {
		PMD_INIT_LOG(ERR, "PF is still resetting");
		goto err_reset_check;
	}

	ret = idpf_hw_mbx_init(hw, idpf_ctlq_info);
	if (ret != 0) {
		PMD_INIT_LOG(ERR, "Failed to init mailbox");
		goto err_reset_check;
	}

	rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities));

error: patch failed: drivers/net/idpf/idpf_ethdev.c:1217
Hunk #5 succeeded at 1280 (offset -157 lines).
Checking patch drivers/net/idpf/idpf_ethdev.h...
Applying patch drivers/net/idpf/idpf_ethdev.c with 3 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Hunk #5 applied cleanly.
Applied patch drivers/net/idpf/idpf_ethdev.h cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c	(rejected hunks)
@@ -1128,6 +1129,23 @@ idpf_dev_alarm_handler(void *param)
 	rte_eal_alarm_set(IDPF_ALARM_INTERVAL, idpf_dev_alarm_handler, adapter);
 }
 
+static int
+idpf_hw_vf_reset_check(struct idpf_hw *hw)
+{
+	uint32_t reg;
+	int i;
+
+	for (i = 0; i < IDPF_RESET_WAIT_CNT; i++) {
+		reg = IDPF_READ_REG(hw, VFGEN_RSTAT);
+		if (reg != 0xFFFFFFFF && (reg & VFGEN_RSTAT_VFR_STATE_M))
+			return 0;
+		rte_delay_ms(1000);
+	}
+
+	PMD_INIT_LOG(ERR, "VF reset timeout");
+	return -EBUSY;
+}
+
 static struct idpf_ctlq_create_info idpf_ctlq_info[IDPF_CTLQ_NUM] = {
 	{
 		.type = IDPF_CTLQ_TYPE_MAILBOX_TX,
@@ -1201,6 +1219,41 @@ static struct virtchnl2_get_capabilities req_caps = {
 	.other_caps = VIRTCHNL2_CAP_WB_ON_ITR
 };
 
+struct idpf_ctlq_create_info vf_ctlq_info[IDPF_CTLQ_NUM] = {
+	{
+		.type = IDPF_CTLQ_TYPE_MAILBOX_TX,
+		.id = IDPF_CTLQ_ID,
+		.len = IDPF_CTLQ_LEN,
+		.buf_size = IDPF_DFLT_MBX_BUF_SIZE,
+		.reg = {
+			.head = VF_ATQH,
+			.tail = VF_ATQT,
+			.len = VF_ATQLEN,
+			.bah = VF_ATQBAH,
+			.bal = VF_ATQBAL,
+			.len_mask = VF_ATQLEN_ATQLEN_M,
+			.len_ena_mask = VF_ATQLEN_ATQENABLE_M,
+			.head_mask = VF_ATQH_ATQH_M,
+		}
+	},
+	{
+		.type = IDPF_CTLQ_TYPE_MAILBOX_RX,
+		.id = IDPF_CTLQ_ID,
+		.len = IDPF_CTLQ_LEN,
+		.buf_size = IDPF_DFLT_MBX_BUF_SIZE,
+		.reg = {
+			.head = VF_ARQH,
+			.tail = VF_ARQT,
+			.len = VF_ARQLEN,
+			.bah = VF_ARQBAH,
+			.bal = VF_ARQBAL,
+			.len_mask = VF_ARQLEN_ARQLEN_M,
+			.len_ena_mask = VF_ARQLEN_ARQENABLE_M,
+			.head_mask = VF_ARQH_ARQH_M,
+		}
+	}
+};
+
 static int
 idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter)
 {
@@ -1217,17 +1270,32 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a
 
 	strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
 
-	idpf_hw_pf_reset(hw);
-	ret = idpf_hw_pf_reset_check(hw);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "PF is still resetting");
-		goto err_reset_check;
-	}
+	if (hw->device_id == IDPF_DEV_ID_PF) {
+		idpf_hw_pf_reset(hw);
+		ret = idpf_hw_pf_reset_check(hw);
+		if (ret != 0) {
+			PMD_INIT_LOG(ERR, "PF is still resetting");
+			goto err_reset_check;
+		}
+
+		ret = idpf_hw_mbx_init(hw, idpf_ctlq_info);
+		if (ret != 0) {
+			PMD_INIT_LOG(ERR, "Failed to init mailbox");
+			goto err_reset_check;
+		}
+	} else if (hw->device_id == IDPF_DEV_ID_VF) {
+		ret = idpf_hw_vf_reset_check(hw);
+		if (ret != 0) {
+			PMD_INIT_LOG(ERR, "VF is still resetting");
+			goto err_reset_check;
+		}
+
+		ret = idpf_hw_mbx_init(hw, vf_ctlq_info);
+		if (ret != 0) {
+			PMD_INIT_LOG(ERR, "Failed to init mailbox");
+			goto err_reset_check;
+		}
 
-	ret = idpf_hw_mbx_init(hw, idpf_ctlq_info);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "Failed to init mailbox");
-		goto err_reset_check;
 	}
 
 	rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities));

https://lab.dpdk.org/results/dashboard/patchsets/25918/

UNH-IOL DPDK Community Lab