From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD89542980 for ; Tue, 18 Apr 2023 21:35:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B89FB4014F; Tue, 18 Apr 2023 21:35:39 +0200 (CEST) Received: from mail-il1-f228.google.com (mail-il1-f228.google.com [209.85.166.228]) by mails.dpdk.org (Postfix) with ESMTP id 28BA34014F for ; Tue, 18 Apr 2023 21:35:39 +0200 (CEST) Received: by mail-il1-f228.google.com with SMTP id e9e14a558f8ab-3294eacb2f6so7406915ab.3 for ; Tue, 18 Apr 2023 12:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1681846538; x=1684438538; h=date:message-id:cc:to:from:subject:from:to:cc:subject:date :message-id:reply-to; bh=VWGGmUYQgkN06LxAzUHrl/3zGDDZ6XLOwoorQrPgbQs=; b=jXPnuqXL18TfKZrI7y3Co6D67tGQ0SnxhIyya2rX68zcCAxyK1Iwz9E++pdTP7vVz6 8Unh7419i1vjtOFtW5mggleboGZnINUnRP8L7iTEE5Jbx8yBauLs8A5W8Amv7K//wC5o k4d4rn4424xFSqoJTaKuTAdop8OPBkkrowDYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681846538; x=1684438538; h=date:message-id:cc:to:from:subject:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VWGGmUYQgkN06LxAzUHrl/3zGDDZ6XLOwoorQrPgbQs=; b=GP/UBN9p3Xi461o1KNiOVEcJeh2iJYuD1WZOVk3Pym6KFFk2CkG0itxodbe8SB7La5 MxEXyHruMB7ePzWhYro67mC9JbkhPGfL1b9Qb89wcRU2SP+weoAcFNtSMYo6wUIaZiIn epLk+m1IfCofe4pT76hcSkdIxtBMJORZ1LL8W0n8HTADdNNo5IhsGsyvbg6lJ4Y6MOkI TQjt7KWDMn4dXJ5p0raUgeRhov7PccrOYzszEMYOnqiXZgUWxtZrm+bP9u8uPBxrzUdG JrD9KnUssAO/rwSmrSqIkIupmiexF1KyJWoTQNRqWpGsaCAEHzm9r9CDiSt6i1vAoj0i sXGg== X-Gm-Message-State: AAQBX9e8dwUjI8mU2eqK8x3glFfC1azcV7LQo8moEg6qx6FTOG+c3mAi W2JWYVAf8DKK7sAICSdNeh/aouUA47VHLMtKM9geZuq8EtNoklFw9v4+yw== X-Google-Smtp-Source: AKy350Zl5zUkDLuQuj2BGlMTp6dDB9cZpGpJKlOc1RhbZmvo87zwkq4u/zi/SitFZoq69+Zos4IUNptCUW0t X-Received: by 2002:a92:2812:0:b0:328:f8c5:bfb3 with SMTP id l18-20020a922812000000b00328f8c5bfb3mr13669764ilf.6.1681846538476; Tue, 18 Apr 2023 12:35:38 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id i12-20020a926d0c000000b00322b8a273a1sm4428129ilc.50.2023.04.18.12.35.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Apr 2023 12:35:38 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from dpdk-ubuntu.dpdklab.iol.unh.edu (unknown [172.18.0.210]) by postal.iol.unh.edu (Postfix) with ESMTP id 0B3FF605246B; Tue, 18 Apr 2023 15:35:38 -0400 (EDT) Received: from dpdk-ubuntu-2.dpdklab.iol.unh.edu (localhost [IPv6:::1]) by dpdk-ubuntu.dpdklab.iol.unh.edu (Postfix) with ESMTP id 0B33C60095; Tue, 18 Apr 2023 19:35:38 +0000 (UTC) Subject: |WARNING| pw126247 [PATCH] [v2] mempool: optimize get objects with constant n From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain Message-Id: <20230418193538.0B33C60095@dpdk-ubuntu.dpdklab.iol.unh.edu> Date: Tue, 18 Apr 2023 19:35:38 +0000 (UTC) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/126247 _apply patch failure_ Submitter: Morten Brorup Date: Tuesday, April 18 2023 15:57:30 Applied on: CommitID:3b3fef9de22af80d173453ab65a80b01ce38cbfd Apply patch set 126247 failed: Checking patch lib/mempool/rte_mempool.h... error: while searching for: unsigned int n, struct rte_mempool_cache *cache) { int ret; unsigned int remaining = n; uint32_t index, len; void **cache_objs; /* No cache provided */ if (unlikely(cache == NULL)) goto driver_dequeue; cache_objs = &cache->objs[cache->len]; error: patch failed: lib/mempool/rte_mempool.h:1492 error: while searching for: return 0; } /* Use the cache as much as we have to return hot objects first */ len = __extension__(__builtin_constant_p(n)) ? cache->len : RTE_MIN(remaining, cache->len); cache->len -= len; remaining -= len; for (index = 0; index < len; index++) *obj_table++ = *--cache_objs; if (!__extension__(__builtin_constant_p(n)) && remaining == 0) { /* The entire request is satisfied from the cache. */ error: patch failed: lib/mempool/rte_mempool.h:1518 Applying patch lib/mempool/rte_mempool.h with 2 rejects... Rejected hunk #1. Rejected hunk #2. hint: Use 'git am --show-current-patch' to see the failed patch diff a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h (rejected hunks) @@ -1492,13 +1492,15 @@ rte_mempool_do_generic_get(struct rte_mempool *mp, void **obj_table, unsigned int n, struct rte_mempool_cache *cache) { int ret; - unsigned int remaining = n; + unsigned int remaining; uint32_t index, len; void **cache_objs; /* No cache provided */ - if (unlikely(cache == NULL)) + if (unlikely(cache == NULL)) { + remaining = n; goto driver_dequeue; + } cache_objs = &cache->objs[cache->len]; @@ -1518,14 +1520,23 @@ rte_mempool_do_generic_get(struct rte_mempool *mp, void **obj_table, return 0; } - /* Use the cache as much as we have to return hot objects first */ + /* + * Use the cache as much as we have to return hot objects first. + * If the request size 'n' is known at build time, the above comparison + * ensures that n > cache->len here, so omit RTE_MIN(). + */ len = __extension__(__builtin_constant_p(n)) ? cache->len : - RTE_MIN(remaining, cache->len); + RTE_MIN(n, cache->len); cache->len -= len; - remaining -= len; + remaining = n - len; for (index = 0; index < len; index++) *obj_table++ = *--cache_objs; + /* + * If the request size 'n' is known at build time, the case + * where the entire request can be satisfied from the cache + * has already been handled above, so omit handling it here. + */ if (!__extension__(__builtin_constant_p(n)) && remaining == 0) { /* The entire request is satisfied from the cache. */ https://lab.dpdk.org/results/dashboard/patchsets/26038/ UNH-IOL DPDK Community Lab