|WARNING| pw126880 [PATCH v2] lib/kni : coding style is fixed

|WARNING| pw126880 [PATCH v2] lib/kni : coding style is fixed

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/126880

_apply patch failure_

Submitter: Yasin CANER <yasinncaner@gmail.com>
Date: Tue, 16 May 2023 11:03:59 +0000
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 29f4afc8f28fc532d64f35cccd0bb41853d67f68

Apply patch set 126880 failed:

/home/zhoumin/dpdk-ci/tools/../series/28007/126880.patch:108: trailing whitespace.
	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ 
Checking patch lib/kni/rte_kni.c...
error: while searching for:
		RTE_LOG(ERR, KNI, "No valid mempool for allocating mbufs\n");
		return;
	}
	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function 
	 * and/or kni_alloc function from mempool.
	 * If alloc_q is completely removed, it shall be allocated again.
	 * */
	allocq = kni_fifo_count(kni->alloc_q);
	/* How many free allocation is possible from mempool. */
	allocq_free = kni_fifo_free_count(kni->alloc_q);
	/* Allocated alloc_q count shall be max MAX_MBUF_BURST_NUM. */
	allocq_count = MAX_MBUF_BURST_NUM - (int)allocq;
	/* Try to figure out how many allocation is possible. allocq_free is max possible.*/
	allocq_free = (allocq_free > MAX_MBUF_BURST_NUM )? MAX_MBUF_BURST_NUM : allocq_free;
	/* Buffer is not removed so no need re-allocate*/

	if(!allocq_count) {
		/* Buffer is not removed so no need re-allocation*/
		return;
	} else if (allocq_free > allocq_count) {

error: patch failed: lib/kni/rte_kni.c:683
error: lib/kni/rte_kni.c: patch does not apply

|WARNING| pw126880 [PATCH v2] lib/kni : coding style is fixed

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/126880

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#108: FILE: lib/kni/rte_kni.c:687:
+^I/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ $

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 27 lines checked

|WARNING| pw126880 [PATCH] [v2] lib/kni : coding style is fixed

[dpdklab]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126880

_apply patch failure_

Submitter: Yasin CANER <yasinncaner@gmail.com>
Date: Tuesday, May 16 2023 11:03:59 
Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c
Apply patch set 126880 failed:

.git/rebase-apply/patch:18: trailing whitespace.
	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ 
Checking patch lib/kni/rte_kni.c...
error: while searching for:
		RTE_LOG(ERR, KNI, "No valid mempool for allocating mbufs\n");
		return;
	}
	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function 
	 * and/or kni_alloc function from mempool.
	 * If alloc_q is completely removed, it shall be allocated again.
	 * */
	allocq = kni_fifo_count(kni->alloc_q);
	/* How many free allocation is possible from mempool. */
	allocq_free = kni_fifo_free_count(kni->alloc_q);
	/* Allocated alloc_q count shall be max MAX_MBUF_BURST_NUM. */
	allocq_count = MAX_MBUF_BURST_NUM - (int)allocq;
	/* Try to figure out how many allocation is possible. allocq_free is max possible.*/
	allocq_free = (allocq_free > MAX_MBUF_BURST_NUM )? MAX_MBUF_BURST_NUM : allocq_free;
	/* Buffer is not removed so no need re-allocate*/

	if(!allocq_count) {
		/* Buffer is not removed so no need re-allocation*/
		return;
	} else if (allocq_free > allocq_count) {

error: patch failed: lib/kni/rte_kni.c:683
Applying patch lib/kni/rte_kni.c with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c	(rejected hunks)
@@ -683,20 +683,21 @@ kni_allocate_mbufs(struct rte_kni *kni)
 		RTE_LOG(ERR, KNI, "No valid mempool for allocating mbufs\n");
 		return;
 	}
-	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function 
-	 * and/or kni_alloc function from mempool.
-	 * If alloc_q is completely removed, it shall be allocated again.
-	 * */
+
+	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ 
+	/* and/or kni_alloc function from mempool.*/
+	/* If alloc_q is completely removed, it shall be allocated again.*/
+
 	allocq = kni_fifo_count(kni->alloc_q);
 	/* How many free allocation is possible from mempool. */
 	allocq_free = kni_fifo_free_count(kni->alloc_q);
 	/* Allocated alloc_q count shall be max MAX_MBUF_BURST_NUM. */
 	allocq_count = MAX_MBUF_BURST_NUM - (int)allocq;
 	/* Try to figure out how many allocation is possible. allocq_free is max possible.*/
-	allocq_free = (allocq_free > MAX_MBUF_BURST_NUM )? MAX_MBUF_BURST_NUM : allocq_free;
+	allocq_free = (allocq_free > MAX_MBUF_BURST_NUM) ? MAX_MBUF_BURST_NUM : allocq_free;
 	/* Buffer is not removed so no need re-allocate*/
 
-	if(!allocq_count) {
+	if (!allocq_count) {
 		/* Buffer is not removed so no need re-allocation*/
 		return;
 	} else if (allocq_free > allocq_count) {

https://lab.dpdk.org/results/dashboard/patchsets/26238/

UNH-IOL DPDK Community Lab