automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw126905 [PATCH] net/nfp: implement xstats functions
@ 2023-05-17  8:36 dpdklab
  0 siblings, 0 replies; 4+ messages in thread
From: dpdklab @ 2023-05-17  8:36 UTC (permalink / raw)
  To: test-report; +Cc: dpdk-test-reports

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126905

_apply patch failure_

Submitter: Chaoyong He <chaoyong.he@corigine.com>
Date: Wednesday, May 17 2023 07:33:51 
Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c
Apply patch set 126905 failed:

Checking patch drivers/net/nfp/nfp_common.c...
error: while searching for:
#include "nfd3/nfp_nfd3.h"
#include "nfdk/nfp_nfdk.h"

#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>

error: patch failed: drivers/net/nfp/nfp_common.c:47
error: while searching for:
#include <stdio.h>
#include <sys/ioctl.h>

static const uint32_t nfp_net_link_speed_nfp2rte[] = {
	[NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = RTE_ETH_SPEED_NUM_NONE,
	[NFP_NET_CFG_STS_LINK_RATE_UNKNOWN]     = RTE_ETH_SPEED_NUM_NONE,

error: patch failed: drivers/net/nfp/nfp_common.c:54
Hunk #3 succeeded at 792 (offset -118 lines).
Checking patch drivers/net/nfp/nfp_common.h...
Checking patch drivers/net/nfp/nfp_ctrl.h...
Hunk #1 succeeded at 334 (offset 5 lines).
Hunk #2 succeeded at 356 (offset 5 lines).
Checking patch drivers/net/nfp/nfp_ethdev.c...
Hunk #1 succeeded at 446 (offset -2 lines).
Hunk #2 succeeded at 556 (offset -2 lines).
Hunk #3 succeeded at 588 (offset -2 lines).
Checking patch drivers/net/nfp/nfp_ethdev_vf.c...
Hunk #1 succeeded at 227 (offset -2 lines).
Hunk #2 succeeded at 338 (offset -2 lines).
Applying patch drivers/net/nfp/nfp_common.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Hunk #3 applied cleanly.
Applied patch drivers/net/nfp/nfp_common.h cleanly.
Applied patch drivers/net/nfp/nfp_ctrl.h cleanly.
Applied patch drivers/net/nfp/nfp_ethdev.c cleanly.
Applied patch drivers/net/nfp/nfp_ethdev_vf.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c	(rejected hunks)
@@ -47,6 +47,7 @@
 #include "nfd3/nfp_nfd3.h"
 #include "nfdk/nfp_nfdk.h"
 
+#include <stdint.h>
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
@@ -54,6 +55,121 @@
 #include <stdio.h>
 #include <sys/ioctl.h>
 
+enum nfp_xstat_group {
+	NFP_XSTAT_GROUP_NET,
+	NFP_XSTAT_GROUP_MAC
+};
+struct nfp_xstat {
+	char name[RTE_ETH_XSTATS_NAME_SIZE];
+	int offset;
+	enum nfp_xstat_group group;
+};
+
+#define NFP_XSTAT_NET(_name, _offset) {                 \
+	.name = _name,                                  \
+	.offset = NFP_NET_CFG_STATS_##_offset,          \
+	.group = NFP_XSTAT_GROUP_NET,                   \
+}
+
+#define NFP_XSTAT_MAC(_name, _offset) {                 \
+	.name = _name,                                  \
+	.offset = NFP_MAC_STATS_##_offset,              \
+	.group = NFP_XSTAT_GROUP_MAC,                   \
+}
+
+static const struct nfp_xstat nfp_net_xstats[] = {
+	/**
+	 * Basic xstats available on both VF and PF.
+	 * Note that in case new statistics of group NFP_XSTAT_GROUP_NET
+	 * are added to this array, they must appear before any statistics
+	 * of group NFP_XSTAT_GROUP_MAC.
+	 */
+	NFP_XSTAT_NET("rx_good_packets_mc", RX_MC_FRAMES),
+	NFP_XSTAT_NET("tx_good_packets_mc", TX_MC_FRAMES),
+	NFP_XSTAT_NET("rx_good_packets_bc", RX_BC_FRAMES),
+	NFP_XSTAT_NET("tx_good_packets_bc", TX_BC_FRAMES),
+	NFP_XSTAT_NET("rx_good_bytes_uc", RX_UC_OCTETS),
+	NFP_XSTAT_NET("tx_good_bytes_uc", TX_UC_OCTETS),
+	NFP_XSTAT_NET("rx_good_bytes_mc", RX_MC_OCTETS),
+	NFP_XSTAT_NET("tx_good_bytes_mc", TX_MC_OCTETS),
+	NFP_XSTAT_NET("rx_good_bytes_bc", RX_BC_OCTETS),
+	NFP_XSTAT_NET("tx_good_bytes_bc", TX_BC_OCTETS),
+	NFP_XSTAT_NET("tx_missed_erros", TX_DISCARDS),
+	NFP_XSTAT_NET("bpf_pass_pkts", APP0_FRAMES),
+	NFP_XSTAT_NET("bpf_pass_bytes", APP0_BYTES),
+	NFP_XSTAT_NET("bpf_app1_pkts", APP1_FRAMES),
+	NFP_XSTAT_NET("bpf_app1_bytes", APP1_BYTES),
+	NFP_XSTAT_NET("bpf_app2_pkts", APP2_FRAMES),
+	NFP_XSTAT_NET("bpf_app2_bytes", APP2_BYTES),
+	NFP_XSTAT_NET("bpf_app3_pkts", APP3_FRAMES),
+	NFP_XSTAT_NET("bpf_app3_bytes", APP3_BYTES),
+	/**
+	 * MAC xstats available only on PF. These statistics are not available for VFs as the
+	 * PF is not initialized when the VF is initialized as it is still bound to the kernel
+	 * driver. As such, the PMD cannot obtain a CPP handle and access the rtsym_table in order
+	 * to get the pointer to the start of the MAC statistics counters.
+	 */
+	NFP_XSTAT_MAC("mac.rx_octets", RX_IN_OCTS),
+	NFP_XSTAT_MAC("mac.rx_frame_too_long_errors", RX_FRAME_TOO_LONG_ERRORS),
+	NFP_XSTAT_MAC("mac.rx_range_length_errors", RX_RANGE_LENGTH_ERRORS),
+	NFP_XSTAT_MAC("mac.rx_vlan_received_ok", RX_VLAN_RECEIVED_OK),
+	NFP_XSTAT_MAC("mac.rx_errors", RX_IN_ERRORS),
+	NFP_XSTAT_MAC("mac.rx_broadcast_pkts", RX_IN_BROADCAST_PKTS),
+	NFP_XSTAT_MAC("mac.rx_drop_events", RX_DROP_EVENTS),
+	NFP_XSTAT_MAC("mac.rx_alignment_errors", RX_ALIGNMENT_ERRORS),
+	NFP_XSTAT_MAC("mac.rx_pause_mac_ctrl_frames", RX_PAUSE_MAC_CTRL_FRAMES),
+	NFP_XSTAT_MAC("mac.rx_frames_received_ok", RX_FRAMES_RECEIVED_OK),
+	NFP_XSTAT_MAC("mac.rx_frame_check_sequence_errors", RX_FRAME_CHECK_SEQ_ERRORS),
+	NFP_XSTAT_MAC("mac.rx_unicast_pkts", RX_UNICAST_PKTS),
+	NFP_XSTAT_MAC("mac.rx_multicast_pkts", RX_MULTICAST_PKTS),
+	NFP_XSTAT_MAC("mac.rx_pkts", RX_PKTS),
+	NFP_XSTAT_MAC("mac.rx_undersize_pkts", RX_UNDERSIZE_PKTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_64_octets", RX_PKTS_64_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_65_to_127_octets", RX_PKTS_65_TO_127_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_128_to_255_octets", RX_PKTS_128_TO_255_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_256_to_511_octets", RX_PKTS_256_TO_511_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_512_to_1023_octets", RX_PKTS_512_TO_1023_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_1024_to_1518_octets", RX_PKTS_1024_TO_1518_OCTS),
+	NFP_XSTAT_MAC("mac.rx_pkts_1519_to_max_octets", RX_PKTS_1519_TO_MAX_OCTS),
+	NFP_XSTAT_MAC("mac.rx_jabbers", RX_JABBERS),
+	NFP_XSTAT_MAC("mac.rx_fragments", RX_FRAGMENTS),
+	NFP_XSTAT_MAC("mac.rx_oversize_pkts", RX_OVERSIZE_PKTS),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class0", RX_PAUSE_FRAMES_CLASS0),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class1", RX_PAUSE_FRAMES_CLASS1),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class2", RX_PAUSE_FRAMES_CLASS2),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class3", RX_PAUSE_FRAMES_CLASS3),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class4", RX_PAUSE_FRAMES_CLASS4),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class5", RX_PAUSE_FRAMES_CLASS5),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class6", RX_PAUSE_FRAMES_CLASS6),
+	NFP_XSTAT_MAC("mac.rx_pause_frames_class7", RX_PAUSE_FRAMES_CLASS7),
+	NFP_XSTAT_MAC("mac.rx_mac_ctrl_frames_received", RX_MAC_CTRL_FRAMES_REC),
+	NFP_XSTAT_MAC("mac.rx_mac_head_drop", RX_MAC_HEAD_DROP),
+	NFP_XSTAT_MAC("mac.tx_queue_drop", TX_QUEUE_DROP),
+	NFP_XSTAT_MAC("mac.tx_octets", TX_OUT_OCTS),
+	NFP_XSTAT_MAC("mac.tx_vlan_transmitted_ok", TX_VLAN_TRANSMITTED_OK),
+	NFP_XSTAT_MAC("mac.tx_errors", TX_OUT_ERRORS),
+	NFP_XSTAT_MAC("mac.tx_broadcast_pkts", TX_BROADCAST_PKTS),
+	NFP_XSTAT_MAC("mac.tx_pause_mac_ctrl_frames", TX_PAUSE_MAC_CTRL_FRAMES),
+	NFP_XSTAT_MAC("mac.tx_frames_transmitted_ok", TX_FRAMES_TRANSMITTED_OK),
+	NFP_XSTAT_MAC("mac.tx_unicast_pkts", TX_UNICAST_PKTS),
+	NFP_XSTAT_MAC("mac.tx_multicast_pkts", TX_MULTICAST_PKTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_64_octets", TX_PKTS_64_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_65_to_127_octets", TX_PKTS_65_TO_127_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_128_to_255_octets", TX_PKTS_128_TO_255_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_256_to_511_octets", TX_PKTS_256_TO_511_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_512_to_1023_octets", TX_PKTS_512_TO_1023_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_1024_to_1518_octets", TX_PKTS_1024_TO_1518_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pkts_1519_to_max_octets", TX_PKTS_1519_TO_MAX_OCTS),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class0", TX_PAUSE_FRAMES_CLASS0),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class1", TX_PAUSE_FRAMES_CLASS1),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class2", TX_PAUSE_FRAMES_CLASS2),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class3", TX_PAUSE_FRAMES_CLASS3),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class4", TX_PAUSE_FRAMES_CLASS4),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class5", TX_PAUSE_FRAMES_CLASS5),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class6", TX_PAUSE_FRAMES_CLASS6),
+	NFP_XSTAT_MAC("mac.tx_pause_frames_class7", TX_PAUSE_FRAMES_CLASS7),
+};
+
 static const uint32_t nfp_net_link_speed_nfp2rte[] = {
 	[NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = RTE_ETH_SPEED_NUM_NONE,
 	[NFP_NET_CFG_STS_LINK_RATE_UNKNOWN]     = RTE_ETH_SPEED_NUM_NONE,

https://lab.dpdk.org/results/dashboard/patchsets/26250/

UNH-IOL DPDK Community Lab

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-17  8:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230517073351.1364030-1-chaoyong.he@corigine.com>
2023-05-17  7:23 ` |SUCCESS| pw126905 [PATCH] net/nfp: implement xstats functions qemudev
2023-05-17  7:27 ` qemudev
2023-05-17  7:34 ` |WARNING| " checkpatch
2023-05-17  8:36 dpdklab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).