From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: julien_dpdk@jaube.fr
Subject: |WARNING| pw126962 [PATCH] drivers/net/bnx2x : Add experimental 2.5Gbps support for BCM578xx.
Date: Thu, 18 May 2023 01:17:25 +0200 (CEST) [thread overview]
Message-ID: <20230517231725.ED131120927@dpdk.org> (raw)
In-Reply-To: <20230517231656.69559-1-julien_dpdk@jaube.fr>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/126962
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56:
This has been tested with GPON's ONU SFP but requires a specific firmware configuration.
WARNING:TYPO_SPELLING: 'advertisment' may be misspelled - perhaps 'advertisement'?
#102: FILE: drivers/net/bnx2x/elink.c:5073:
+ /* Note that 2.5G works only when used with 1G advertisment */
ERROR:CODE_INDENT: code indent should use tabs where possible
#102: FILE: drivers/net/bnx2x/elink.c:5073:
+ /* Note that 2.5G works only when used with 1G advertisment */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+ if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+ if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+ if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&
[...]
+ elink_cl45_write(sc, phy, MDIO_WC_DEVAD,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed == SPEED_2500'
#103: FILE: drivers/net/bnx2x/elink.c:5074:
+ if (fiber_mode && (phy->req_line_speed == SPEED_2500) &&
+ (phy->speed_cap_mask &
+ (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |
+ PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#104: FILE: drivers/net/bnx2x/elink.c:5075:
+ (phy->speed_cap_mask &$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: drivers/net/bnx2x/elink.c:5075:
+ (phy->speed_cap_mask &$
ERROR:CODE_INDENT: code indent should use tabs where possible
#105: FILE: drivers/net/bnx2x/elink.c:5076:
+ (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/net/bnx2x/elink.c:5076:
+ (PORT_HW_CFG_SPEED_CAPABILITY_D0_1G |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#106: FILE: drivers/net/bnx2x/elink.c:5077:
+ PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#106: FILE: drivers/net/bnx2x/elink.c:5077:
+ PORT_HW_CFG_SPEED_CAPABILITY_D0_2_5G))) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#107: FILE: drivers/net/bnx2x/elink.c:5078:
+ elink_cl45_write(sc, phy, MDIO_WC_DEVAD,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: drivers/net/bnx2x/elink.c:5078:
+ elink_cl45_write(sc, phy, MDIO_WC_DEVAD,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#108: FILE: drivers/net/bnx2x/elink.c:5079:
+ MDIO_WC_REG_SERDESDIGITAL_MISC1,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: drivers/net/bnx2x/elink.c:5079:
+ MDIO_WC_REG_SERDESDIGITAL_MISC1,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#109: FILE: drivers/net/bnx2x/elink.c:5080:
+ 0x6010);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: drivers/net/bnx2x/elink.c:5080:
+ 0x6010);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: drivers/net/bnx2x/elink.c:5081:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: drivers/net/bnx2x/elink.c:5081:
+ }$
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed != ELINK_SPEED_1000'
#136: FILE: drivers/net/bnx2x/elink.c:9167:
+ if ((phy->req_line_speed != ELINK_SPEED_1000) &&
+ (phy->req_line_speed != ELINK_SPEED_2500)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->req_line_speed != ELINK_SPEED_2500'
#136: FILE: drivers/net/bnx2x/elink.c:9167:
+ if ((phy->req_line_speed != ELINK_SPEED_1000) &&
+ (phy->req_line_speed != ELINK_SPEED_2500)) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: drivers/net/bnx2x/elink.c:9168:
+ (phy->req_line_speed != ELINK_SPEED_2500)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/net/bnx2x/elink.c:9168:
+ (phy->req_line_speed != ELINK_SPEED_2500)) {$
CHECK:CAMELCASE: Avoid CamelCase: <ELINK_SUPPORTED_2500baseX_Full>
#154: FILE: drivers/net/bnx2x/elink.c:12631:
+ ELINK_SUPPORTED_2500baseX_Full |
total: 10 errors, 12 warnings, 4 checks, 84 lines checked
next prev parent reply other threads:[~2023-05-17 23:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230517231656.69559-1-julien_dpdk@jaube.fr>
2023-05-17 23:05 ` |SUCCESS| " qemudev
2023-05-17 23:09 ` qemudev
2023-05-17 23:17 ` checkpatch [this message]
2023-05-18 0:20 ` 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517231725.ED131120927@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=julien_dpdk@jaube.fr \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).