From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Subject: |WARNING| pw128224 [PATCH v4] gro : ipv6 changes to support GRO for TCP/ipv6
Date: Tue, 6 Jun 2023 16:59:27 +0200 (CEST) [thread overview]
Message-ID: <20230606145927.5A92512077C@dpdk.org> (raw)
In-Reply-To: <20230606145802.53671-1-kumaraparamesh92@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128224
_coding style issues_
ERROR:TRAILING_WHITESPACE: trailing whitespace
#204: FILE: lib/gro/gro_tcp.c:75:
+int32_t $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#205: FILE: lib/gro/gro_tcp.c:76:
+gro_process_tcp_item(struct rte_mbuf *pkt, $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#221: FILE: lib/gro/gro_tcp.c:92:
+^Isent_seq = rte_be_to_cpu_32(tcp_hdr->sent_seq);^I$
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#241: FILE: lib/gro/gro_tcp.c:112:
+ if (insert_new_tcp_item(pkt, items, item_num, max_item_num, start_time, cur_idx,
ERROR:TRAILING_WHITESPACE: trailing whitespace
#297: FILE: lib/gro/gro_tcp.h:34:
+^I} while (0) $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#341: FILE: lib/gro/gro_tcp.h:78:
+delete_tcp_item(struct gro_tcp_item *items, $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#342: FILE: lib/gro/gro_tcp.h:79:
+^I^Iuint32_t item_idx, $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#346: FILE: lib/gro/gro_tcp.h:83:
+int32_t $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#347: FILE: lib/gro/gro_tcp.h:84:
+gro_process_tcp_item(struct rte_mbuf *pkt, $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#576: FILE: lib/gro/gro_tcp4.c:101:
+^IASSIGN_TCP_FLOW_KEY((&src->tcp_flow), (&dst->tcp_flow));^I$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#687: FILE: lib/gro/gro_tcp4.c:191:
+^I^Isent_seq = rte_be_to_cpu_32(tcp_hdr->sent_seq);^I$
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#688: FILE: lib/gro/gro_tcp4.c:192:
+ item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,
ERROR:TRAILING_WHITESPACE: trailing whitespace
#738: FILE: lib/gro/gro_tcp4.c:211:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#768: FILE: lib/gro/gro_tcp4.c:254:
+ j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#1177: FILE: lib/gro/gro_tcp6.c:194:
+ item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1186: FILE: lib/gro/gro_tcp6.c:203:
+ * stored packet.
+ */
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1194: FILE: lib/gro/gro_tcp6.c:211:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1222: FILE: lib/gro/gro_tcp6.c:239:
+ j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1401: FILE: lib/gro/gro_tcp6.h:146:
+ if (memcmp(&k1->src_addr, &k2->src_addr, 16)) {
+ return 0;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1404: FILE: lib/gro/gro_tcp6.h:149:
+ if (memcmp(&k1->dst_addr, &k2->dst_addr, 16)) {
+ return 0;
+ }
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1408: FILE: lib/gro/gro_tcp6.h:153:
+ /*
+ * IP version (4) Traffic Class (8) Flow Label (20)
total: 12 errors, 9 warnings, 1512 lines checked
next prev parent reply other threads:[~2023-06-06 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230606145802.53671-1-kumaraparamesh92@gmail.com>
2023-06-06 14:57 ` |SUCCESS| " qemudev
2023-06-06 14:59 ` checkpatch [this message]
2023-06-06 15:01 ` qemudev
2023-06-06 16:39 ` 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606145927.5A92512077C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kumaraparamesh92@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).