From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>
Subject: |WARNING| pw128501 [RFC] lib/ethdev: introduce table driven APIs
Date: Mon, 12 Jun 2023 04:56:59 +0200 (CEST) [thread overview]
Message-ID: <20230612025659.8A07B12077C@dpdk.org> (raw)
In-Reply-To: <20230612111539.462084-1-qi.z.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128501
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#156:
rte_flow_table_info_get_by_name(port_id, "decap_vxlan_tcp_table", &tbl_info);
WARNING:TYPO_SPELLING: 'destoried' may be misspelled - perhaps 'destroyed'?
#406: FILE: lib/ethdev/rte_flow_table.h:143:
+ int ref_cnt; /**< Reference count, in async ops it prevents the object be destoried .*/
WARNING:TYPO_SPELLING: 'destoried' may be misspelled - perhaps 'destroyed'?
#422: FILE: lib/ethdev/rte_flow_table.h:159:
+ int ref_cnt; /**< Reference count, in async ops it prevents the object be destoried .*/
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#495: FILE: lib/ethdev/rte_flow_table.h:232:
+ * @warning
+* @b EXPERIMENTAL: this API may change without prior notice.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#496: FILE: lib/ethdev/rte_flow_table.h:233:
+* @b EXPERIMENTAL: this API may change without prior notice.
+ *
ERROR:CODE_INDENT: code indent should use tabs where possible
#906: FILE: lib/ethdev/rte_flow_table.h:643:
+^I^I^I^I struct rte_flow_table_key *key,$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#963: FILE: lib/ethdev/rte_flow_table.h:700:
+ * @param[in] prefix $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#991: FILE: lib/ethdev/rte_flow_table.h:728:
+ * @param[in] name $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#997: FILE: lib/ethdev/rte_flow_table.h:734:
+ * @param[in] prefix $
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1009: FILE: lib/ethdev/rte_flow_table.h:746:
+ const char* name,
WARNING:TYPO_SPELLING: 'indiates' may be misspelled - perhaps 'indicates'?
#1435: FILE: lib/ethdev/rte_flow_table.h:1172:
+ * >=0 on success, indiates the number of status be pulled.
WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#1473: FILE: lib/ethdev/rte_flow_table.h:1210:
+ * Get a PNA queue identifer from a ethdev Rx queue.
WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#1501: FILE: lib/ethdev/rte_flow_table.h:1238:
+ * Get a PNA queue identifer from a ethdev Tx queue.
total: 5 errors, 8 warnings, 1261 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
prev parent reply other threads:[~2023-06-12 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230612111539.462084-1-qi.z.zhang@intel.com>
2023-06-12 2:45 ` |SUCCESS| " qemudev
2023-06-12 2:49 ` qemudev
2023-06-12 2:56 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612025659.8A07B12077C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).