automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Subject: |WARNING| pw128506 [PATCH v5] gro : ipv6 changes to support GRO for TCP/ipv6
Date: Mon, 12 Jun 2023 13:06:44 +0200 (CEST)	[thread overview]
Message-ID: <20230612110644.B7A0712077C@dpdk.org> (raw)
In-Reply-To: <20230612110511.68338-1-kumaraparamesh92@gmail.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128506

_coding style issues_


WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#325: FILE: lib/gro/gro_tcp4.c:191:
+		item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#404: FILE: lib/gro/gro_tcp4.c:252:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#813: FILE: lib/gro/gro_tcp6.c:193:
+		item_idx = insert_new_tcp_item(pkt, tbl->items, &tbl->item_num, tbl->max_item_num, start_time,

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#822: FILE: lib/gro/gro_tcp6.c:202:
+			 * stored packet.
+			*/

ERROR:TRAILING_WHITESPACE: trailing whitespace
#830: FILE: lib/gro/gro_tcp6.c:210:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#858: FILE: lib/gro/gro_tcp6.c:238:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1037: FILE: lib/gro/gro_tcp6.h:146:
+	if (memcmp(&k1->src_addr, &k2->src_addr, 16)) {
+		return 0;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1040: FILE: lib/gro/gro_tcp6.h:149:
+	if (memcmp(&k1->dst_addr, &k2->dst_addr, 16)) {
+		return 0;
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1044: FILE: lib/gro/gro_tcp6.h:153:
+	/*
+	* IP version (4) Traffic Class (8) Flow Label (20)

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1172: FILE: lib/gro/gro_tcp_internal.c:112:
+			if (insert_new_tcp_item(pkt, items, item_num, max_item_num, start_time, cur_idx,

total: 1 errors, 9 warnings, 1506 lines checked

      parent reply	other threads:[~2023-06-12 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230612110511.68338-1-kumaraparamesh92@gmail.com>
2023-06-12 10:54 ` |SUCCESS| " qemudev
2023-06-12 10:58 ` qemudev
2023-06-12 11:06 ` checkpatch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612110644.B7A0712077C@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=kumaraparamesh92@gmail.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).