|WARNING| pw128644 [PATCH v5 2/3] net/iavf: support Rx timestamp offload on AVX2

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zhichao Zeng <zhichaox.zeng@intel.com>
Subject: |WARNING| pw128644 [PATCH v5 2/3] net/iavf: support Rx timestamp offload on AVX2
Date: Wed, 14 Jun 2023 03:45:48 +0200 (CEST)	[thread overview]
Message-ID: <20230614014548.180A31208D8@dpdk.org> (raw)
In-Reply-To: <20230614014948.3495063-3-zhichaox.zeng@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128644

_coding style issues_


WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#165: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1165:
+					__m256i ts_desp_mask = _mm256_set_epi32(mask, 0, 0, 0, mask, 0, 0, 0);

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#167: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1167:
+					__m256i ts_permute_mask = _mm256_set_epi32(7, 3, 6, 2, 5, 1, 4, 0);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#170: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1170:
+					ts_low = _mm256_or_si256(ts_low, _mm256_srli_si256(ts, 3 * 4));

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#172: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1172:
+					ts_low = _mm256_or_si256(ts_low, _mm256_srli_si256(ts, 2 * 4));

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#178: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1178:
+					ts_low1 = _mm256_permutevar8x32_epi32(ts_low, ts_permute_mask);

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#180: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1180:
+								_mm256_set_epi32(6, 5, 4, 3, 2, 1, 0, 7));

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#182: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1182:
+								_mm256_set_epi32(mask, mask, mask, mask, mask, mask, mask, 0));

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#185: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1185:
+								_mm256_set_epi32(0, 0, 0, 0, 0, 0, 0, mask));

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#188: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1188:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 0);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#190: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1190:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 1);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#192: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1192:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 2);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#194: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1194:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 3);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#196: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1196:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 4);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#198: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1198:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 5);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#200: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1200:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 6);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#202: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1202:
+						iavf_timestamp_dynfield_offset, uint32_t *) = _mm256_extract_epi32(ts_low1, 7);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#206: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1206:
+						if (iavf_get_phc_time(rxq))

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#209: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1209:
+								iavf_timestamp_dynfield_offset, uint32_t *);

WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#210: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1210:
+						rxq->phc_time = iavf_tstamp_convert_32b_64b(rxq->phc_time, in_timestamp);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#214: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1214:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#216: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1216:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#218: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1218:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#220: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1220:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#222: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1222:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#224: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1224:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#226: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1226:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#228: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1228:
+						iavf_timestamp_dynfield_offset + 4, uint32_t *) = (uint32_t)(rxq->phc_time >> 32);

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#231: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1231:
+					cmp_ret = _mm256_andnot_si256(_mm256_cmpeq_epi32(max_ret, ts_low1), cmp_mask);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#237: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1237:
+						while (shift > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#241: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1241:
+							switch (shift) {

WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#243: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1243:
+								mask_low = _mm256_set_epi32(0, 0, 0, 0, mask, mask, mask, mask);

WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#244: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1244:
+								mask_high = _mm256_set_epi32(mask, mask, mask, mask, 0, 0, 0, 0);

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#247: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1247:
+								mask_low = _mm256_srli_si256(cmp_mask, 2 * 4);

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#248: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1248:
+								mask_high = _mm256_slli_si256(cmp_mask, 2 * 4);

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#251: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1251:
+								mask_low = _mm256_srli_si256(cmp_mask, 1 * 4);

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#252: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1252:
+								mask_high = _mm256_slli_si256(cmp_mask, 1 * 4);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#256: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1256:
+							if (ret) {

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#257: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1257:
+								ret = _mm256_testz_si256(cmp_ret, mask_high);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#260: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1260:
+							} else {

WARNING:LONG_LINE: line length of 124 exceeds 100 columns
#265: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1265:
+					mbuf_flags = _mm256_or_si256(mbuf_flags, _mm256_set1_epi32(iavf_timestamp_dynflag));

WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#328: FILE: drivers/net/iavf/iavf_rxtx_vec_avx2.c:1452:
+		rxq->phc_time = *RTE_MBUF_DYNFIELD(rx_pkts[received - 1], iavf_timestamp_dynfield_offset, rte_mbuf_timestamp_t *);

total: 0 errors, 41 warnings, 0 checks, 235 lines checked

          parent reply	other threads:[~2023-06-14  1:45 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230614014948.3495063-3-zhichaox.zeng@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614014548.180A31208D8@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).