From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Artemii Morozov <artemii.morozov@arknetworks.am>
Subject: |WARNING| pw128946 [PATCH v8 2/4] common/sfc_efx/base: add API to get installed filters count
Date: Fri, 23 Jun 2023 07:49:39 +0200 (CEST) [thread overview]
Message-ID: <20230623054939.24AA41208DB@dpdk.org> (raw)
In-Reply-To: <20230623054756.8896-3-artemii.morozov@arknetworks.am>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128946
_coding style issues_
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#91: FILE: drivers/common/sfc_efx/base/ef10_filter.c:2133:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#146: FILE: drivers/common/sfc_efx/base/efx_filter.c:315:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#165: FILE: drivers/common/sfc_efx/base/efx_filter.c:334:
+ if ((rc = enp->en_efop->efo_get_count(enp, countp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#168: FILE: drivers/common/sfc_efx/base/efx_filter.c:337:
+ return (0);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#186: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+ efx_rc_t (*efo_get_count)(efx_nic_t *, uint32_t *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#186: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+ efx_rc_t (*efo_get_count)(efx_nic_t *, uint32_t *);
total: 4 errors, 2 warnings, 113 lines checked
parent reply other threads:[~2023-06-23 5:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230623054756.8896-3-artemii.morozov@arknetworks.am>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623054939.24AA41208DB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=artemii.morozov@arknetworks.am \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).