From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2061042D2C
	for <public@inbox.dpdk.org>; Fri, 23 Jun 2023 07:49:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1D36C42C4D;
	Fri, 23 Jun 2023 07:49:42 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 30FB840E09
 for <test-report@dpdk.org>; Fri, 23 Jun 2023 07:49:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 24AA41208DB; Fri, 23 Jun 2023 07:49:39 +0200 (CEST)
Subject: |WARNING| pw128946 [PATCH v8 2/4] common/sfc_efx/base: add API to get
 installed filters count
In-Reply-To: <20230623054756.8896-3-artemii.morozov@arknetworks.am>
References: <20230623054756.8896-3-artemii.morozov@arknetworks.am>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Artemii Morozov <artemii.morozov@arknetworks.am>
Message-Id: <20230623054939.24AA41208DB@dpdk.org>
Date: Fri, 23 Jun 2023 07:49:39 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128946

_coding style issues_


ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#91: FILE: drivers/common/sfc_efx/base/ef10_filter.c:2133:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#146: FILE: drivers/common/sfc_efx/base/efx_filter.c:315:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#165: FILE: drivers/common/sfc_efx/base/efx_filter.c:334:
+	if ((rc = enp->en_efop->efo_get_count(enp, countp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#168: FILE: drivers/common/sfc_efx/base/efx_filter.c:337:
+	return (0);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#186: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#186: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

total: 4 errors, 2 warnings, 113 lines checked