From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: |WARNING| pw131825 [RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces
Date: Fri, 22 Sep 2023 10:20:35 +0200 (CEST) [thread overview]
Message-ID: <20230922082035.0D500120802@dpdk.org> (raw)
In-Reply-To: <20230922081912.7090-5-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131825
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#110: FILE: app/io-proxy/command_fns.c:15:
+extern volatile bool running_startup_script;
WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#404: FILE: app/io-proxy/datapath.c:131:
+ char *argv[] = {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#738: FILE: app/io-proxy/datapath.c:465:
+ return EEXIST;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#743: FILE: app/io-proxy/datapath.c:470:
+ return EINVAL;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#751: FILE: app/io-proxy/datapath.c:478:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EADDRINUSE)
#775: FILE: app/io-proxy/datapath.c:502:
+ return EADDRINUSE;
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1005: FILE: app/io-proxy/main.c:4:
+#include <stdio.h>
total: 0 errors, 7 warnings, 966 lines checked
parent reply other threads:[~2023-09-22 8:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230922081912.7090-5-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922082035.0D500120802@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).