automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw131825 [RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces
       [not found] <20230922081912.7090-5-bruce.richardson@intel.com>
@ 2023-09-22  8:20 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2023-09-22  8:20 UTC (permalink / raw)
  To: test-report; +Cc: Bruce Richardson

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131825

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#110: FILE: app/io-proxy/command_fns.c:15:
+extern volatile bool running_startup_script;

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#404: FILE: app/io-proxy/datapath.c:131:
+	char *argv[] = {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#738: FILE: app/io-proxy/datapath.c:465:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#743: FILE: app/io-proxy/datapath.c:470:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#751: FILE: app/io-proxy/datapath.c:478:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EADDRINUSE)
#775: FILE: app/io-proxy/datapath.c:502:
+			return EADDRINUSE;

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1005: FILE: app/io-proxy/main.c:4:
+#include <stdio.h>

total: 0 errors, 7 warnings, 966 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-22  8:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230922081912.7090-5-bruce.richardson@intel.com>
2023-09-22  8:20 ` |WARNING| pw131825 [RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).