From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8855D42612
	for <public@inbox.dpdk.org>; Fri, 22 Sep 2023 10:20:36 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 827FE40648;
	Fri, 22 Sep 2023 10:20:36 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 11509402E2
 for <test-report@dpdk.org>; Fri, 22 Sep 2023 10:20:35 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 0D500120802; Fri, 22 Sep 2023 10:20:35 +0200 (CEST)
Subject: |WARNING| pw131825 [RFC PATCH 4/5] app: add IO proxy app using shared
 memory interfaces
In-Reply-To: <20230922081912.7090-5-bruce.richardson@intel.com>
References: <20230922081912.7090-5-bruce.richardson@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Message-Id: <20230922082035.0D500120802@dpdk.org>
Date: Fri, 22 Sep 2023 10:20:35 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131825

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#110: FILE: app/io-proxy/command_fns.c:15:
+extern volatile bool running_startup_script;

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#404: FILE: app/io-proxy/datapath.c:131:
+	char *argv[] = {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#738: FILE: app/io-proxy/datapath.c:465:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#743: FILE: app/io-proxy/datapath.c:470:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#751: FILE: app/io-proxy/datapath.c:478:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EADDRINUSE)
#775: FILE: app/io-proxy/datapath.c:502:
+			return EADDRINUSE;

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1005: FILE: app/io-proxy/main.c:4:
+#include <stdio.h>

total: 0 errors, 7 warnings, 966 lines checked