From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: |WARNING| pw132817 [PATCH v2 16/19] ethdev: use rte optional stdatomic API
Date: Tue, 17 Oct 2023 22:34:45 +0200 (CEST) [thread overview]
Message-ID: <20231017203445.D6C8B1206A9@dpdk.org> (raw)
In-Reply-To: <1697574677-16578-17-git-send-email-roretzla@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/132817
_coding style issues_
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#132: FILE: lib/ethdev/ethdev_driver.h:1658:
+ RTE_ATOMIC(uint64_t) *dev_link = (uint64_t __rte_atomic *)&(dev->data->dev_link);
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#152: FILE: lib/ethdev/ethdev_driver.h:1685:
+ RTE_ATOMIC(uint64_t) *src = (uint64_t __rte_atomic *)&(dev->data->dev_link);
^
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#180: FILE: lib/ethdev/ethdev_private.c:281:
+ fpo->rxq.clbk = (void * __rte_atomic *)(uintptr_t)dev->post_rx_burst_cbs;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#184: FILE: lib/ethdev/ethdev_private.c:284:
+ fpo->txq.clbk = (void * __rte_atomic *)(uintptr_t)dev->pre_tx_burst_cbs;
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#251: FILE: lib/ethdev/rte_ethdev.c:5794:
+ RTE_ATOMIC(struct rte_eth_rxtx_callback *) *prev_cb;
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#269: FILE: lib/ethdev/rte_ethdev.c:5831:
+ RTE_ATOMIC(struct rte_eth_rxtx_callback *) *prev_cb;
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#333: FILE: lib/ethdev/rte_ethdev_core.h:74:
+ RTE_ATOMIC(void *) *clbk;
^
total: 7 errors, 0 warnings, 199 lines checked
parent reply other threads:[~2023-10-17 20:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1697574677-16578-17-git-send-email-roretzla@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017203445.D6C8B1206A9@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).