From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1170243190
	for <public@inbox.dpdk.org>; Tue, 17 Oct 2023 22:34:53 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0CB5040E0F;
	Tue, 17 Oct 2023 22:34:53 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id D9D1940E0F
 for <test-report@dpdk.org>; Tue, 17 Oct 2023 22:34:45 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id D6C8B1206A9; Tue, 17 Oct 2023 22:34:45 +0200 (CEST)
Subject: |WARNING| pw132817 [PATCH v2 16/19] ethdev: use rte optional
 stdatomic API
In-Reply-To: <1697574677-16578-17-git-send-email-roretzla@linux.microsoft.com>
References: <1697574677-16578-17-git-send-email-roretzla@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Message-Id: <20231017203445.D6C8B1206A9@dpdk.org>
Date: Tue, 17 Oct 2023 22:34:45 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/132817

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#132: FILE: lib/ethdev/ethdev_driver.h:1658:
+	RTE_ATOMIC(uint64_t) *dev_link = (uint64_t __rte_atomic *)&(dev->data->dev_link);
 	                     ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#152: FILE: lib/ethdev/ethdev_driver.h:1685:
+	RTE_ATOMIC(uint64_t) *src = (uint64_t __rte_atomic *)&(dev->data->dev_link);
 	                     ^

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#180: FILE: lib/ethdev/ethdev_private.c:281:
+	fpo->rxq.clbk = (void * __rte_atomic *)(uintptr_t)dev->post_rx_burst_cbs;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#184: FILE: lib/ethdev/ethdev_private.c:284:
+	fpo->txq.clbk = (void * __rte_atomic *)(uintptr_t)dev->pre_tx_burst_cbs;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#251: FILE: lib/ethdev/rte_ethdev.c:5794:
+	RTE_ATOMIC(struct rte_eth_rxtx_callback *) *prev_cb;
 	                                           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#269: FILE: lib/ethdev/rte_ethdev.c:5831:
+	RTE_ATOMIC(struct rte_eth_rxtx_callback *) *prev_cb;
 	                                           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#333: FILE: lib/ethdev/rte_ethdev_core.h:74:
+	RTE_ATOMIC(void *) *clbk;
 	                   ^

total: 7 errors, 0 warnings, 199 lines checked