From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 37B2A432EA
	for <public@inbox.dpdk.org>; Thu,  9 Nov 2023 21:14:30 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 31A26402EA;
	Thu,  9 Nov 2023 21:14:30 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 769ED402EA
 for <test-report@dpdk.org>; Thu,  9 Nov 2023 21:14:28 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 6ADA7120DB4; Thu,  9 Nov 2023 21:14:28 +0100 (CET)
Subject: |WARNING| pw134036 [PATCH] ethdev: add extension keyword to statement
 expression macro
In-Reply-To: <1699560818-7453-1-git-send-email-roretzla@linux.microsoft.com>
References: <1699560818-7453-1-git-send-email-roretzla@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Message-Id: <20231109201428.6ADA7120DB4@dpdk.org>
Date: Thu,  9 Nov 2023 21:14:28 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/134036

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#104: FILE: lib/ethdev/rte_tm.c:43:
+#define RTE_TM_FUNC(port_id, func)			\
+__extension__ ({					\
 	const struct rte_tm_ops *ops =			\
 		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)				\
 		return -rte_errno;			\
 							\
 	if (ops->func == NULL)				\

total: 0 errors, 1 warnings, 40 lines checked