From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5E198436A9
	for <public@inbox.dpdk.org>; Fri,  8 Dec 2023 13:43:11 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 57551402D7;
	Fri,  8 Dec 2023 13:43:11 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 582024029E
 for <test-report@dpdk.org>; Fri,  8 Dec 2023 13:43:10 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 435C8120D36; Fri,  8 Dec 2023 13:43:10 +0100 (CET)
Subject: |WARNING| pw134960 [PATCH] examples/packet_ordering: fix segfault in
 disable_reorder mode
In-Reply-To: <20231208124231.198138-1-qi_an_hao@126.com>
References: <20231208124231.198138-1-qi_an_hao@126.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Qian Hao <qi_an_hao@126.com>
Message-Id: <20231208124310.435C8120D36@dpdk.org>
Date: Fri,  8 Dec 2023 13:43:10 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/134960

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#63: 
When reorder is enabled, send_thread uses sequence number generated in rx_thread (Line 459) to enforce packet ordering. Otherwise rx_thread just sends any packet it receives.

WARNING:BRACES: braces {} are not necessary for single statement blocks
#83: FILE: examples/packet_ordering/main.c:459:
+					for (i = 0; i < nb_rx_pkts;) {
+						*rte_reorder_seqn(pkts[i++]) = seqn++;              
+					}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#84: FILE: examples/packet_ordering/main.c:460:
+^I^I^I^I^I^I*rte_reorder_seqn(pkts[i++]) = seqn++;              $

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings, 13 lines checked