From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16B35436D9 for ; Wed, 13 Dec 2023 02:49:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 130B042E93; Wed, 13 Dec 2023 02:49:01 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E906B402B8 for ; Wed, 13 Dec 2023 02:48:43 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id DD251121E3C; Wed, 13 Dec 2023 02:48:43 +0100 (CET) Subject: |WARNING| pw135089 [PATCH 15/26] net/qede: replace RTE_LOG_DP with rte_log_dp In-Reply-To: <20231213014408.612051-16-stephen@networkplumber.org> References: <20231213014408.612051-16-stephen@networkplumber.org> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Stephen Hemminger Message-Id: <20231213014843.DD251121E3C@dpdk.org> Date: Wed, 13 Dec 2023 02:48:43 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/135089 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #101: FILE: drivers/net/qede/qede_logs.h:61: +#define PMD_TX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qded_logtype_driver, \ + "%s(): port=%u queue=%u " fmt " ", \ __func__, q->port_id, q->queue_id, ## args) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues #101: FILE: drivers/net/qede/qede_logs.h:61: +#define PMD_TX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qded_logtype_driver, \ + "%s(): port=%u queue=%u " fmt " ", \ __func__, q->port_id, q->queue_id, ## args) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #112: FILE: drivers/net/qede/qede_logs.h:70: +#define PMD_RX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qded_logtype_driver, \ + "%s(): port=%u queue=%u " fmt " ", \ __func__, q->port_id, q->queue_id, ## args) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues #112: FILE: drivers/net/qede/qede_logs.h:70: +#define PMD_RX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qded_logtype_driver, \ + "%s(): port=%u queue=%u " fmt " ", \ __func__, q->port_id, q->queue_id, ## args) total: 0 errors, 0 warnings, 4 checks, 22 lines checked