From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw135149 [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with rte_log_dp
Date: Wed, 13 Dec 2023 17:41:00 +0100 (CET) [thread overview]
Message-ID: <20231213164100.4D023121E47@dpdk.org> (raw)
In-Reply-To: <20231213163820.894987-15-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135149
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#103: FILE: drivers/net/qede/qede_logs.h:61:
+#define PMD_TX_LOG(level, q, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, qede_logtype_driver, \
+ "%s(): port=%u queue=%u " fmt "
", \
__func__, q->port_id, q->queue_id, ## args)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#103: FILE: drivers/net/qede/qede_logs.h:61:
+#define PMD_TX_LOG(level, q, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, qede_logtype_driver, \
+ "%s(): port=%u queue=%u " fmt "
", \
__func__, q->port_id, q->queue_id, ## args)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#114: FILE: drivers/net/qede/qede_logs.h:70:
+#define PMD_RX_LOG(level, q, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, qede_logtype_driver, \
+ "%s(): port=%u queue=%u " fmt "
", \
__func__, q->port_id, q->queue_id, ## args)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#114: FILE: drivers/net/qede/qede_logs.h:70:
+#define PMD_RX_LOG(level, q, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, qede_logtype_driver, \
+ "%s(): port=%u queue=%u " fmt "
", \
__func__, q->port_id, q->queue_id, ## args)
total: 0 errors, 0 warnings, 4 checks, 22 lines checked
parent reply other threads:[~2023-12-13 16:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20231213163820.894987-15-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213164100.4D023121E47@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).