From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9C694436E3
	for <public@inbox.dpdk.org>; Wed, 13 Dec 2023 17:41:10 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5991A42F27;
	Wed, 13 Dec 2023 17:41:10 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 537E642F83
 for <test-report@dpdk.org>; Wed, 13 Dec 2023 17:41:00 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 4D023121E47; Wed, 13 Dec 2023 17:41:00 +0100 (CET)
Subject: |WARNING| pw135149 [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with
 rte_log_dp
In-Reply-To: <20231213163820.894987-15-stephen@networkplumber.org>
References: <20231213163820.894987-15-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20231213164100.4D023121E47@dpdk.org>
Date: Wed, 13 Dec 2023 17:41:00 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135149

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#103: FILE: drivers/net/qede/qede_logs.h:61:
+#define PMD_TX_LOG(level, q, fmt, args...)			\
+	rte_log(RTE_LOG_ ## level, qede_logtype_driver,		\
+		"%s(): port=%u queue=%u " fmt "
",		\
 		__func__, q->port_id, q->queue_id, ## args)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#103: FILE: drivers/net/qede/qede_logs.h:61:
+#define PMD_TX_LOG(level, q, fmt, args...)			\
+	rte_log(RTE_LOG_ ## level, qede_logtype_driver,		\
+		"%s(): port=%u queue=%u " fmt "
",		\
 		__func__, q->port_id, q->queue_id, ## args)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#114: FILE: drivers/net/qede/qede_logs.h:70:
+#define PMD_RX_LOG(level, q, fmt, args...)			\
+	rte_log(RTE_LOG_ ## level, qede_logtype_driver,		\
+		"%s(): port=%u queue=%u " fmt "
",		\
 		__func__, q->port_id, q->queue_id, ## args)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#114: FILE: drivers/net/qede/qede_logs.h:70:
+#define PMD_RX_LOG(level, q, fmt, args...)			\
+	rte_log(RTE_LOG_ ## level, qede_logtype_driver,		\
+		"%s(): port=%u queue=%u " fmt "
",		\
 		__func__, q->port_id, q->queue_id, ## args)

total: 0 errors, 0 warnings, 4 checks, 22 lines checked