From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw135163 [PATCH v3 28/37] raw/cnxk_gpio: replace PMD logtype with dynamic type
Date: Wed, 13 Dec 2023 17:43:19 +0100 (CET) [thread overview]
Message-ID: <20231213164319.2DB33121E47@dpdk.org> (raw)
In-Reply-To: <20231213163820.894987-29-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135163
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#229: FILE: drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c:59:
+#define CNXK_GPIO_ERR_STR(err, str, ...) do { \
+ if (err) { \
+ CNXK_LOG(ERR, "%s:%d: " str " (%d)",__func__, __LINE__, \
+ ##__VA_ARGS__, err); \
+ goto out; \
+ } \
} while (0)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#231: FILE: drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c:61:
+ CNXK_LOG(ERR, "%s:%d: " str " (%d)",__func__, __LINE__, \
^
total: 1 errors, 1 warnings, 169 lines checked
parent reply other threads:[~2023-12-13 16:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20231213163820.894987-29-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213164319.2DB33121E47@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).