automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: madhuker.mythri@oracle.com
Subject: |WARNING| pw135855 [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements.
Date: Fri, 12 Jan 2024 14:51:05 +0100 (CET)	[thread overview]
Message-ID: <20240112135105.6BFF412485B@dpdk.org> (raw)
In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135855

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#90: 
When multiple queues configured, internally RSS will be enabled and thus TAP BPF RSS byte-code will be loaded on to the Kernel using BPF system calls.

WARNING:TYPO_SPELLING: 'sucessfully' may be misspelled - perhaps 'successfully'?
#107: 
BPF instructions able to load sucessfully on to the Kernel tap device.

WARNING:BRACES: braces {} are not necessary for single statement blocks
#657: FILE: drivers/net/tap/bpf/tap_bpf_program.c:120:
+	if (rsskey == NULL) {
 		return TC_ACT_OK;
 	}

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#759: FILE: drivers/net/tap/bpf/tap_bpf_program.c:148:
+							bpf_ntohl(n6h.ip6h.saddr.in6_u.u6_addr32[j]);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#761: FILE: drivers/net/tap/bpf/tap_bpf_program.c:150:
+							bpf_ntohl(n6h.ip6h.daddr.in6_u.u6_addr32[j]);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#767: FILE: drivers/net/tap/bpf/tap_bpf_program.c:156:
+		}
+		else {

CHECK:BRACES: Unbalanced braces around else statement
#767: FILE: drivers/net/tap/bpf/tap_bpf_program.c:156:
+		else {

ERROR:SPACING: space required before the open parenthesis '('
#788: FILE: drivers/net/tap/bpf/tap_bpf_program.c:168:
+		if(k == hash)

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#805: FILE: drivers/net/tap/bpf/tap_bpf_program.c:176:
 
+}

WARNING:TYPO_SPELLING: 'aded' may be misspelled - perhaps 'added'?
#1811: FILE: drivers/net/tap/tap_bpf_insns.h:646:
+	{0xa7,    5,    0,        0, 0x40e8aded},

total: 2 errors, 6 warnings, 2 checks, 3314 lines checked

       reply	other threads:[~2024-01-12 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240112134821.2067-1-madhuker.mythri@oracle.com>
2024-01-12 13:51 ` checkpatch [this message]
2024-01-12 15:15 ` |SUCCESS| " 0-day Robot
2024-01-15  6:04 ` qemudev
2024-01-15  6:08 ` qemudev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112135105.6BFF412485B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=madhuker.mythri@oracle.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).