From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B9C62438A3
	for <public@inbox.dpdk.org>; Fri, 12 Jan 2024 14:51:06 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B500F402EC;
	Fri, 12 Jan 2024 14:51:06 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 7A8C54025E
 for <test-report@dpdk.org>; Fri, 12 Jan 2024 14:51:05 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 6BFF412485B; Fri, 12 Jan 2024 14:51:05 +0100 (CET)
Subject: |WARNING| pw135855 [PATCH] net/tap: Modified TAP BPF program as per
 the Kernel-version upgrade requirements.
In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com>
References: <20240112134821.2067-1-madhuker.mythri@oracle.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: madhuker.mythri@oracle.com
Message-Id: <20240112135105.6BFF412485B@dpdk.org>
Date: Fri, 12 Jan 2024 14:51:05 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135855

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#90: 
When multiple queues configured, internally RSS will be enabled and thus TAP BPF RSS byte-code will be loaded on to the Kernel using BPF system calls.

WARNING:TYPO_SPELLING: 'sucessfully' may be misspelled - perhaps 'successfully'?
#107: 
BPF instructions able to load sucessfully on to the Kernel tap device.

WARNING:BRACES: braces {} are not necessary for single statement blocks
#657: FILE: drivers/net/tap/bpf/tap_bpf_program.c:120:
+	if (rsskey == NULL) {
 		return TC_ACT_OK;
 	}

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#759: FILE: drivers/net/tap/bpf/tap_bpf_program.c:148:
+							bpf_ntohl(n6h.ip6h.saddr.in6_u.u6_addr32[j]);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#761: FILE: drivers/net/tap/bpf/tap_bpf_program.c:150:
+							bpf_ntohl(n6h.ip6h.daddr.in6_u.u6_addr32[j]);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#767: FILE: drivers/net/tap/bpf/tap_bpf_program.c:156:
+		}
+		else {

CHECK:BRACES: Unbalanced braces around else statement
#767: FILE: drivers/net/tap/bpf/tap_bpf_program.c:156:
+		else {

ERROR:SPACING: space required before the open parenthesis '('
#788: FILE: drivers/net/tap/bpf/tap_bpf_program.c:168:
+		if(k == hash)

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#805: FILE: drivers/net/tap/bpf/tap_bpf_program.c:176:
 
+}

WARNING:TYPO_SPELLING: 'aded' may be misspelled - perhaps 'added'?
#1811: FILE: drivers/net/tap/tap_bpf_insns.h:646:
+	{0xa7,    5,    0,        0, 0x40e8aded},

total: 2 errors, 6 warnings, 2 checks, 3314 lines checked