From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw135857 [RFC v3] tap: rework the BPF header parsing
Date: Fri, 12 Jan 2024 18:56:07 +0100 (CET) [thread overview]
Message-ID: <20240112175607.81F7312485B@dpdk.org> (raw)
In-Reply-To: <20240112175347.126080-1-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135857
_coding style issues_
WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'?
#86:
- split IPv4 and IPv6 into seperate functions
ERROR:SPACING: space prohibited after that open parenthesis '('
#678: FILE: drivers/net/tap/bpf/tap_bpf_program.c:104:
+ if ( (iph.frag_off & bpf_htons(IP_MF | IP_OFFSET)) != 0 &&
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#788: FILE: drivers/net/tap/bpf/tap_bpf_program.c:140:
+ if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#795: FILE: drivers/net/tap/bpf/tap_bpf_program.c:147:
+ if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))
total: 1 errors, 3 warnings, 0 checks, 3936 lines checked
next parent reply other threads:[~2024-01-12 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240112175347.126080-1-stephen@networkplumber.org>
2024-01-12 17:56 ` checkpatch [this message]
2024-01-15 5:53 ` |SUCCESS| " qemudev
2024-01-15 5:57 ` |FAILURE| " qemudev
2024-01-15 7:22 ` |SUCCESS| " qemudev
2024-01-15 7:26 ` qemudev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112175607.81F7312485B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).