From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Joshua Washington <joshwash@google.com>
Subject: |WARNING| pw136053 [PATCH 5/7] net/gve: RSS redirection table update support
Date: Tue, 23 Jan 2024 01:18:49 +0100 (CET) [thread overview]
Message-ID: <20240123001849.4D38C122B9C@dpdk.org> (raw)
In-Reply-To: <20240123001645.1507779-6-joshwash@google.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136053
_coding style issues_
ERROR:C99_COMMENTS: do not use C99 // comments
#110: FILE: drivers/net/gve/gve_ethdev.c:783:
+ // RSS key must be set before the redirection table can be set.
ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#137: FILE: drivers/net/gve/gve_ethdev.c:810:
+ table_id ++;
^
ERROR:C99_COMMENTS: do not use C99 // comments
#164: FILE: drivers/net/gve/gve_ethdev.c:837:
+ // RSS key must be set before the redirection table can be queried.
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#182: FILE: drivers/net/gve/gve_ethdev.c:855:
+ reta_conf[table_id].reta[table_entry]
+ = priv->rss_config.indir[i];
ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#185: FILE: drivers/net/gve/gve_ethdev.c:858:
+ table_id ++;
^
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 5 errors, 0 warnings, 1 checks, 113 lines checked
parent reply other threads:[~2024-01-23 0:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240123001645.1507779-6-joshwash@google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123001849.4D38C122B9C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=joshwash@google.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).