From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 12FBD4399F
	for <public@inbox.dpdk.org>; Tue, 23 Jan 2024 01:18:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0E242406B8;
	Tue, 23 Jan 2024 01:18:54 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 577B740273
 for <test-report@dpdk.org>; Tue, 23 Jan 2024 01:18:49 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 4D38C122B9C; Tue, 23 Jan 2024 01:18:49 +0100 (CET)
Subject: |WARNING| pw136053 [PATCH 5/7] net/gve: RSS redirection table update
 support
In-Reply-To: <20240123001645.1507779-6-joshwash@google.com>
References: <20240123001645.1507779-6-joshwash@google.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Joshua Washington <joshwash@google.com>
Message-Id: <20240123001849.4D38C122B9C@dpdk.org>
Date: Tue, 23 Jan 2024 01:18:49 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136053

_coding style issues_


ERROR:C99_COMMENTS: do not use C99 // comments
#110: FILE: drivers/net/gve/gve_ethdev.c:783:
+	// RSS key must be set before the redirection table can be set.

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#137: FILE: drivers/net/gve/gve_ethdev.c:810:
+			table_id ++;
 			         ^

ERROR:C99_COMMENTS: do not use C99 // comments
#164: FILE: drivers/net/gve/gve_ethdev.c:837:
+	// RSS key must be set before the redirection table can be queried.

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#182: FILE: drivers/net/gve/gve_ethdev.c:855:
+			reta_conf[table_id].reta[table_entry]
+				= priv->rss_config.indir[i];

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#185: FILE: drivers/net/gve/gve_ethdev.c:858:
+			table_id ++;
 			         ^

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 5 errors, 0 warnings, 1 checks, 113 lines checked